Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SCP transfer syntax negotiation quirk #417

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Fix SCP transfer syntax negotiation quirk #417

merged 1 commit into from
Sep 23, 2023

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Sep 23, 2023

This fixes a quirk in dicom_ul that I found while working on #408. Affects the behavior of dicom-storescp so that --uncompressed-only actually functions as originally intended.

Summary

  • Only accept all transfer syntaxes supported by the central transfer syntax registry if no transfer syntaxes were explicitly added via with_transfer_syntax
  • add test that covers selecting a transfer syntax other than the first one proposed by the SCU.

@Enet4
Fix SCP transfer syntax negotiation quirk
52a7c63 
- only accept all supported TSes
  if no TSes were explicitly added
  via `with_transfer_syntax`
- add test that covers selecting
  a TS other than the first one proposed by the SCU
@Enet4 Enet4 added bug This is a bug A-lib Area: library C-ul Crate: dicom-ul labels Sep 23, 2023
@Enet4 Enet4 merged commit 354fb06 into master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library bug This is a bug C-ul Crate: dicom-ul
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Enet4