Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project maintenance (2023-10) #427

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Project maintenance (2023-10) #427

merged 2 commits into from
Oct 30, 2023

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Oct 30, 2023

  • Update Cargo lock files
  • Update GitHub actions workflow

@Enet4 Enet4 added the chore For keeping the project tidy label Oct 30, 2023
@Enet4
Copy link
Owner Author

Enet4 commented Oct 30, 2023

Re failed job:

---- value::partial::tests::test_dicom_time stdout ----
thread 'value::partial::tests::test_dicom_time' panicked at core/src/value/partial.rs:972:87:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/std/src/panicking.rs:597:5
   1: core::panicking::panic_fmt
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:127:5
   3: core::option::Option<T>::unwrap
   4: dicom_core::value::partial::tests::test_dicom_time
   5: dicom_core::value::partial::tests::test_dicom_time::{{closure}}
   6: core::ops::function::FnOnce::call_once
   7: core::ops::function::FnOnce::call_once
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/ops/function.rs:250:5

It points to this part:

        assert!(matches!(
            DicomTime::try_from(&NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000).unwrap()),
            Err(Error::InvalidComponent {
                component: DateComponent::Fraction,
                ..
            })
        ));

It appears that NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000) was not accepted by chrono this time. Checking if this is consistent.

- cargo update
- update actions/checkout
- merge Clippy run onto main Linux job
- add check on macOS
@Enet4 Enet4 merged commit 3fb3279 into master Oct 30, 2023
4 checks passed
@Enet4 Enet4 deleted the chore/maintenance-2023-10 branch October 30, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For keeping the project tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant