Add function for changing charset with unit test. #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-tribus
commented
Feb 14, 2024
thomas-tribus
commented
- Creates a function to change the charset
- Adds a unit test to test if the sequences have invalid length when converting into tokens
- Does not yet change the generation of tokens yet.
Enet4
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Thank you very much for the initiative, @thomas-tribus! It may be so that we ought to pass charset_changed along into the IntoTokens implementation.
From looking at the test method, I should note that the data set writer might already choose to ignore the encoded element lengths and pick the real byte length instead (#172). This is probably not happening for SQs yet because without the flag, we did not have a way to know in advance whether making the SQ length undefined is needed.
More comments inline.
|
Thanks @Enet4, I don't have time today, so I'll look at this tomorrow 👍 |
|
@Enet4 I had a quick look at how I could add the flag to |
thomas-tribus
force-pushed
the
change/change_charset
branch
2 times, most recently
from
0becca5
to
07bfd5a
Compare
thomas-tribus
commented
Feb 16, 2024
thomas-tribus
force-pushed
the
change/change_charset
branch
2 times, most recently
from
bfe4c44
to
392d275
Compare
thomas-tribus
commented
Feb 23, 2024
thomas-tribus
force-pushed
the
change/change_charset
branch
from
392d275
to
012ce48
Compare
Enet4
added
the
breaking change
thomas-tribus
force-pushed
the
change/change_charset
branch
from
012ce48
to
926baba
Compare
Enet4
reviewed
Feb 23, 2024
thomas-tribus
force-pushed
the
change/change_charset
branch
from
926baba
to
8cf1065
Compare
thomas-tribus
force-pushed
the
change/change_charset
branch
from
8cf1065
to
693c671
Compare
Enet4
reviewed
Mar 1, 2024
- Creates a function to change the charset - Adds a unit test to test if the sequences have invalid length when converting into tokens - When putting the 'specific charset' token, set a flag to invalidate all lengths when writing the dicom - In the token generation code, check and pass this token, marking all lengths as UNDEFINED
Enet4
force-pushed
the
change/change_charset
branch
from
693c671
to
846a53e
Compare
Enet4
reviewed
Mar 24, 2024
Enet4
approved these changes
Mar 27, 2024
|
Happy to contribute in a very small way!
…On Wed, Mar 27, 2024 at 2:44 PM Eduardo Pinho ***@***.***> wrote:
***@***.**** approved this pull request.
Ready to bring this in. 👍 Thanks again, @thomas-tribus
<https://github.com/thomas-tribus>!
—
Reply to this email directly, view it on GitHub
<#456 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHQ42RZPCYBTCQBAOJYAKTY2K5KLAVCNFSM6AAAAABDIGKT7WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRTGM3TSNZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.