Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] Allow arbitrary element order for JsonDataElement #459

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Mar 4, 2024

Keep the value of the "value" entry in memory until all fields have been read. This allows the "vr" field to occur after the "value" field

@Enet4 Enet4 added A-lib Area: library C-json Crate: dicom-json labels Mar 4, 2024
@feliwir feliwir mentioned this pull request Mar 6, 2024
3 tasks
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a very minor suggestion inline, but other than that looks pretty good! Thank you @feliwir for reporting this case and providing a patch!

json/src/de/mod.rs Outdated Show resolved Hide resolved
json/src/de/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
json/src/de/mod.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Enet4 Enet4 merged commit ee1c818 into Enet4:master Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lib Area: library C-json Crate: dicom-json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants