Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for unknown OB length #48

Merged
merged 2 commits into from
Jun 21, 2020

Conversation

robyoung
Copy link
Contributor

@robyoung robyoung commented Jun 5, 2020

This test makes use of a DICOM file that was originally from pydicom that contains an OB field with unknown length.

This makes use of the dicom-test-files crate that provides access to
DICOM files that can be used for testing across different DICOM readers.

This test makes use of a DICOM file that was originally from pydicom
that contains an OB field with unknown length.

This makes use of the dicom-test-files crate that provides access to
DICOM files that can be used for testing across different DICOM readers.
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Please consider the minor tweaks below before it's merged.

object/tests/integration_test.rs Outdated Show resolved Hide resolved
object/tests/integration_test.rs Show resolved Hide resolved
@Enet4 Enet4 merged commit 841b6ca into Enet4:master Jun 21, 2020
@Enet4
Copy link
Owner

Enet4 commented Jun 21, 2020

I will take the liberty of applying minor changes later. Thank you again, @robyoung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants