Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ul] (break) improve Pdu::short_description #488

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[ul] (break) improve Pdu::short_description #488

merged 2 commits into from
Apr 12, 2024

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Mar 27, 2024

Summary

  • change return type of short_description to impl Display
  • add private type to impl Display which does not allocate a String

@Enet4
[ul] (break) improve Pdu::short_description
46b8adc 
- change return type to impl Display
- impl Display which does not allocate a String
@Enet4 Enet4 added enhancement breaking change Hint that this may require a major version bump on release A-lib Area: library C-ul Crate: dicom-ul labels Mar 27, 2024
@Enet4 Enet4 added this to the DICOM-rs 0.7 milestone Apr 8, 2024
@Enet4
[ul] Clippy lint
c4a982d 
- needless_borrow in Pdu::short_description
@Enet4 Enet4 merged commit b1c76ed into master Apr 12, 2024
4 checks passed
@Enet4 Enet4 deleted the change/ul/pdu-short-description branch April 12, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library breaking change Hint that this may require a major version bump on release C-ul Crate: dicom-ul enhancement
Projects
None yet
Milestone
DICOM-rs 0.7
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Enet4