Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parse Specific Character Set error #52

Merged
merged 1 commit into from
Jun 13, 2020
Merged

fix parse Specific Character Set error #52

merged 1 commit into from
Jun 13, 2020

Conversation

kira-96
Copy link

@kira-96 kira-96 commented Jun 13, 2020 •
edited by Enet4

Fixed an error in parsing character encoding and added support for Chinese characters.

Resolves #51.

@kira-96 kira-96 mentioned this pull request Jun 13, 2020
Closed
Enet4
Enet4 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes, nice catch! I am preparing a PR to provide test coverage over this part of the decoder, which I can also merge after this one.

Thank you very much!

@Enet4 Enet4 merged commit 7c608f7 into Enet4:master Jun 13, 2020
This was referenced Jun 13, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse Specific Charset error.
2 participants
@kira-96 @Enet4