-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block_fade event #456
Add block_fade event #456
Conversation
Is there any case where data won't be 0? |
@@ -124,4 +124,10 @@ public void onNotePlay(NotePlayEvent e) { | |||
BukkitBlockEvents.BukkitMCNotePlayEvent npe = new BukkitBlockEvents.BukkitMCNotePlayEvent(e); | |||
EventUtils.TriggerListener(Driver.NOTE_PLAY, "note_play", npe); | |||
} | |||
|
|||
@EventHandler(priority = EventPriority.LOWEST) | |||
public void onBloackFade(BlockFadeEvent e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bloack.
"data" means e.getBlock.getData() ? |
What block can fade that has data other than 0? |
51(fire), others I don't know |
Oh, right. I can't think of a reason to prefilter that, though. I think olddata, newtype, and newdata should be removed from prefilters, as they serve no purpose. Only oldtype and world are meaningful prefilters here. |
Okay I'll remove it now |
Add block_fade event