Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
TomyLobo committed Mar 14, 2023
1 parent e2b5e81 commit 2855333
Show file tree
Hide file tree
Showing 9 changed files with 206 additions and 72 deletions.
38 changes: 22 additions & 16 deletions worldedit-core/src/main/java/com/sk89q/worldedit/LocalSession.java
Expand Up @@ -46,6 +46,7 @@
import com.sk89q.worldedit.regions.selector.CuboidRegionSelector;
import com.sk89q.worldedit.regions.selector.RegionSelectorType;
import com.sk89q.worldedit.session.ClipboardHolder;
import com.sk89q.worldedit.session.Placement;
import com.sk89q.worldedit.session.request.Request;
import com.sk89q.worldedit.util.Countable;
import com.sk89q.worldedit.util.SideEffectSet;
Expand Down Expand Up @@ -93,7 +94,7 @@ public class LocalSession {

// Session related
private transient RegionSelector selector = new CuboidRegionSelector();
private transient boolean placeAtPos1 = false;
private transient Placement placement = Placement.PLAYER;
private final transient LinkedList<EditSession> history = new LinkedList<>();
private transient int historyPointer = 0;
private transient ClipboardHolder clipboard;
Expand Down Expand Up @@ -559,34 +560,39 @@ public boolean toggleSuperPickAxe() {
* @throws IncompleteRegionException thrown if a region is not fully selected
*/
public BlockVector3 getPlacementPosition(Actor actor) throws IncompleteRegionException {
checkNotNull(actor);
if (!placeAtPos1) {
if (actor instanceof Locatable) {
return ((Locatable) actor).getBlockLocation().toVector().toBlockPoint();
} else {
throw new IncompleteRegionException();
}
}
return placement.getPlacementPosition(selector, actor);
}

return selector.getPrimaryPosition();
public Placement getPlacement() {
return placement;
}

public void setPlacement(Placement placement) {
this.placement = placement;
}

@Deprecated
public void setPlaceAtPos1(boolean placeAtPos1) {
this.placeAtPos1 = placeAtPos1;
this.placement = placeAtPos1 ? Placement.POS1 : Placement.PLAYER;
}

@Deprecated
public boolean isPlaceAtPos1() {
return placeAtPos1;
return placement == Placement.POS1;
}

/**
* Toggle placement position.
* Toggle placement position between POS1 and PLAYER.
*
* @return whether "place at position 1" is now enabled
* @return whether placement is now at position 1
*/
public boolean togglePlacementPosition() {
placeAtPos1 = !placeAtPos1;
return placeAtPos1;
if (placement == Placement.POS1) {
this.placement = Placement.PLAYER;
} else {
this.placement = Placement.POS1;
}
return placement == Placement.POS1;
}

/**
Expand Down
Expand Up @@ -28,7 +28,6 @@
import com.sk89q.worldedit.command.util.CommandPermissions;
import com.sk89q.worldedit.command.util.CommandPermissionsConditionGenerator;
import com.sk89q.worldedit.command.util.HookMode;
import com.sk89q.worldedit.command.util.Placement;
import com.sk89q.worldedit.command.util.WorldEditAsyncCommandBuilder;
import com.sk89q.worldedit.entity.Player;
import com.sk89q.worldedit.extension.platform.Actor;
Expand All @@ -43,6 +42,7 @@
import com.sk89q.worldedit.internal.command.CommandRegistrationHandler;
import com.sk89q.worldedit.internal.command.CommandUtil;
import com.sk89q.worldedit.internal.cui.ServerCUIHandler;
import com.sk89q.worldedit.session.Placement;
import com.sk89q.worldedit.util.SideEffect;
import com.sk89q.worldedit.util.SideEffectSet;
import com.sk89q.worldedit.util.auth.AuthorizationException;
Expand Down Expand Up @@ -435,14 +435,11 @@ public void togglePlace(Actor actor, LocalSession session,
}
if (placement == null) {
session.togglePlacementPosition();
placement = session.getPlacement();
} else {
session.setPlaceAtPos1(placement == Placement.POS1);
}
if (session.isPlaceAtPos1()) {
actor.printInfo(TranslatableComponent.of("worldedit.toggleplace.pos1"));
} else {
actor.printInfo(TranslatableComponent.of("worldedit.toggleplace.player"));
session.setPlacement(placement);
}
actor.printInfo(placement.getInfo());
}

@Command(
Expand Down
Expand Up @@ -22,7 +22,6 @@
import com.google.common.collect.ImmutableSet;
import com.sk89q.worldedit.EditSession;
import com.sk89q.worldedit.command.util.HookMode;
import com.sk89q.worldedit.command.util.Placement;
import com.sk89q.worldedit.extent.TracingExtent;
import com.sk89q.worldedit.util.SideEffect;
import com.sk89q.worldedit.util.TreeGenerator;
Expand Down Expand Up @@ -58,8 +57,6 @@ public static void register(CommandManager commandManager) {
basic(HookMode.class));
commandManager.registerConverter(Key.of(TracingExtent.Action.class),
basic(TracingExtent.Action.class));
commandManager.registerConverter(Key.of(Placement.class),
basic(Placement.class));
}

private static <E extends Enum<E>> ArgumentConverter<E> basic(Class<E> enumClass) {
Expand Down
Expand Up @@ -55,7 +55,7 @@ public static void register(WorldEdit worldEdit, CommandManager commandManager)
private final VectorConverter<Integer, BlockVector3> vectorConverter =
VectorConverter.BLOCK_VECTOR_3_CONVERTER;

private OffsetConverter(WorldEdit worldEdit) {
OffsetConverter(WorldEdit worldEdit) {
directionVectorConverter = new DirectionVectorConverter(worldEdit, true);
}

Expand Down
@@ -0,0 +1,128 @@
/*
* WorldEdit, a Minecraft world manipulation toolkit
* Copyright (C) sk89q <http://www.sk89q.com>
* Copyright (C) WorldEdit team and contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

package com.sk89q.worldedit.command.argument;

import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.sk89q.worldedit.IncompleteRegionException;
import com.sk89q.worldedit.extension.platform.Actor;
import com.sk89q.worldedit.math.BlockVector3;
import com.sk89q.worldedit.regions.RegionSelector;
import com.sk89q.worldedit.session.Placement;
import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TextComponent;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;
import org.enginehub.piston.CommandManager;
import org.enginehub.piston.converter.ArgumentConverter;
import org.enginehub.piston.converter.ConversionResult;
import org.enginehub.piston.converter.SuccessfulConversion;
import org.enginehub.piston.inject.InjectedValueAccess;
import org.enginehub.piston.inject.Key;

import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;

public class PlacementConverter implements ArgumentConverter<Placement> {

private static final List<String> FIXED_SUGGESTIONS = Arrays.asList(
"pos1",
"player"
);

public static void register(CommandManager commandManager) {
commandManager.registerConverter(
Key.of(Placement.class),
new PlacementConverter()
);
}
private final VectorConverter<Integer, BlockVector3> vectorConverter = VectorConverter.BLOCK_VECTOR_3_CONVERTER;

@Override
public Component describeAcceptableArguments() {
return TextComponent.builder()
.append(String.join(", ", FIXED_SUGGESTIONS))
.append(", or ")
.append(vectorConverter.describeAcceptableArguments())
.build();
}

@Override
public List<String> getSuggestions(String input, InjectedValueAccess context) {
return ImmutableList.copyOf(Iterables.concat(
FIXED_SUGGESTIONS,
vectorConverter.getSuggestions(input, context)
));
}

@Override
public ConversionResult<Placement> convert(String input, InjectedValueAccess context) {
switch (input) {
case "pos1":
return SuccessfulConversion.fromSingle(Placement.POS1);

case "player":
return SuccessfulConversion.fromSingle(Placement.PLAYER);

default:
if (input.startsWith("^")) {
return vectorConverter.convert(input.substring(1), context)
.map(collection -> collection.stream()
.map(vector -> new Placement() {
@Override
public BlockVector3 getPlacementPosition(RegionSelector selector, Actor actor) throws IncompleteRegionException {
return Placement.PLAYER.getPlacementPosition(selector, actor).add(vector);
}

@Override
public Component getInfo() {
return TranslatableComponent.of("worldedit.toggleplace.relative-player",
TextComponent.of(vector.getX()),
TextComponent.of(vector.getY()),
TextComponent.of(vector.getZ())
);
}
})
.collect(Collectors.toList())
);
} else {
return vectorConverter.convert(input, context)
.map(collection -> collection.stream()
.map(vector -> new Placement() {
@Override
public BlockVector3 getPlacementPosition(RegionSelector selector, Actor actor) throws IncompleteRegionException {
return vector;
}

@Override
public Component getInfo() {
return TranslatableComponent.of("worldedit.toggleplace.absolute",
TextComponent.of(vector.getX()),
TextComponent.of(vector.getY()),
TextComponent.of(vector.getZ())
);
}
})
.collect(Collectors.toList())
);
}
}
}
}

This file was deleted.

Expand Up @@ -67,27 +67,7 @@
import com.sk89q.worldedit.command.UtilityCommandsRegistration;
import com.sk89q.worldedit.command.WorldEditCommands;
import com.sk89q.worldedit.command.WorldEditCommandsRegistration;
import com.sk89q.worldedit.command.argument.Arguments;
import com.sk89q.worldedit.command.argument.BooleanConverter;
import com.sk89q.worldedit.command.argument.Chunk3dVectorConverter;
import com.sk89q.worldedit.command.argument.ClipboardFormatConverter;
import com.sk89q.worldedit.command.argument.ClipboardShareDestinationConverter;
import com.sk89q.worldedit.command.argument.CommaSeparatedValuesConverter;
import com.sk89q.worldedit.command.argument.DirectionConverter;
import com.sk89q.worldedit.command.argument.DirectionVectorConverter;
import com.sk89q.worldedit.command.argument.EntityRemoverConverter;
import com.sk89q.worldedit.command.argument.EnumConverter;
import com.sk89q.worldedit.command.argument.FactoryConverter;
import com.sk89q.worldedit.command.argument.HeightConverter;
import com.sk89q.worldedit.command.argument.OffsetConverter;
import com.sk89q.worldedit.command.argument.RegionFactoryConverter;
import com.sk89q.worldedit.command.argument.RegistryConverter;
import com.sk89q.worldedit.command.argument.SelectorChoiceConverter;
import com.sk89q.worldedit.command.argument.SideEffectConverter;
import com.sk89q.worldedit.command.argument.SideEffectSetConverter;
import com.sk89q.worldedit.command.argument.VectorConverter;
import com.sk89q.worldedit.command.argument.WorldConverter;
import com.sk89q.worldedit.command.argument.ZonedDateTimeConverter;
import com.sk89q.worldedit.command.argument.*;
import com.sk89q.worldedit.command.util.PermissionCondition;
import com.sk89q.worldedit.command.util.SubCommandPermissionCondition;
import com.sk89q.worldedit.entity.Entity;
Expand Down Expand Up @@ -232,6 +212,7 @@ private void registerArgumentConverters() {
ClipboardFormatConverter.register(commandManager);
ClipboardShareDestinationConverter.register(commandManager);
SelectorChoiceConverter.register(commandManager);
PlacementConverter.register(commandManager);
}

private void registerAlwaysInjectedValues() {
Expand Down
@@ -0,0 +1,47 @@
package com.sk89q.worldedit.session;

import com.sk89q.worldedit.IncompleteRegionException;
import com.sk89q.worldedit.LocalSession;
import com.sk89q.worldedit.extension.platform.Actor;
import com.sk89q.worldedit.extension.platform.Locatable;
import com.sk89q.worldedit.math.BlockVector3;
import com.sk89q.worldedit.regions.RegionSelector;
import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;

import static com.google.common.base.Preconditions.checkNotNull;

public interface Placement {
Placement PLAYER = new Placement() {
@Override
public BlockVector3 getPlacementPosition(RegionSelector selector, Actor actor) throws IncompleteRegionException {
checkNotNull(actor);
if (actor instanceof Locatable) {
return ((Locatable) actor).getBlockLocation().toVector().toBlockPoint();
} else {
throw new IncompleteRegionException();
}
}

@Override
public Component getInfo() {
return TranslatableComponent.of("worldedit.toggleplace.player");
}
};

Placement POS1 = new Placement() {
@Override
public BlockVector3 getPlacementPosition(RegionSelector selector, Actor actor) throws IncompleteRegionException {
return selector.getPrimaryPosition();
}

@Override
public Component getInfo() {
return TranslatableComponent.of("worldedit.toggleplace.pos1");
}
};

BlockVector3 getPlacementPosition(RegionSelector selector, Actor actor) throws IncompleteRegionException;

Component getInfo();
}
2 changes: 2 additions & 0 deletions worldedit-core/src/main/resources/lang/strings.json
Expand Up @@ -70,6 +70,8 @@
"worldedit.gmask.set": "Global mask set.",
"worldedit.toggleplace.pos1": "Now placing at pos #1.",
"worldedit.toggleplace.player": "Now placing at the block you stand in.",
"worldedit.toggleplace.relative-player": "Now placing at ({0}, {1}, {2}) from the block you stand in.",
"worldedit.toggleplace.absolute": "Now placing at ({0}, {1}, {2}).",
"worldedit.toggleplace.not-locatable": "Cannot toggle placing in this context.",
"worldedit.searchitem.too-short": "Enter a longer search string (len > 2).",
"worldedit.searchitem.either-b-or-i": "You cannot use both the 'b' and 'i' flags simultaneously.",
Expand Down

0 comments on commit 2855333

Please sign in to comment.