Skip to content

Commit

Permalink
Fix SideEffectSet.none() being the default set (#1620)
Browse files Browse the repository at this point in the history
* Fix SideEffectSet.none() being the default set

* Remove the unnecessary private empty constructor for SideEffectSet

* Back to ImmutableMap.of
  • Loading branch information
me4502 committed Dec 22, 2020
1 parent 544793d commit 98c4580
Showing 1 changed file with 3 additions and 7 deletions.
Expand Up @@ -30,19 +30,15 @@
import java.util.stream.Collectors;

public class SideEffectSet {
private static final SideEffectSet DEFAULT = new SideEffectSet(
Arrays.stream(SideEffect.values()).collect(Collectors.toMap(Function.identity(), SideEffect::getDefaultValue))
private static final SideEffectSet DEFAULT = new SideEffectSet(ImmutableMap.of());
private static final SideEffectSet NONE = new SideEffectSet(
Arrays.stream(SideEffect.values()).collect(Collectors.toMap(Function.identity(), state -> SideEffect.State.OFF))
);
private static final SideEffectSet NONE = new SideEffectSet();

private final Map<SideEffect, SideEffect.State> sideEffects;
private final Set<SideEffect> appliedSideEffects;
private final boolean appliesAny;

private SideEffectSet() {
this(ImmutableMap.of());
}

public SideEffectSet(Map<SideEffect, SideEffect.State> sideEffects) {
this.sideEffects = Maps.immutableEnumMap(sideEffects);

Expand Down

0 comments on commit 98c4580

Please sign in to comment.