Fix Artifactory interfering with Fabric publications

EngineHub · Feb 18, 2024 · f07254b · f07254b
1 parent 8c656bd
commit f07254b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/buildSrc/src/main/kotlin/ArtifactoryConfig.kt b/buildSrc/src/main/kotlin/ArtifactoryConfig.kt
@@ -34,7 +34,10 @@ fun Project.applyRootArtifactoryConfig() {
 }
 
 fun Project.applyCommonArtifactoryConfig() {
-    tasks.named<ArtifactoryTask>("artifactoryPublish") {
-        publications("maven")
+    // Artifactory eagerly evaluates publications, so this must run after all changes to artifacts are done
+    afterEvaluate {
+        tasks.named<ArtifactoryTask>("artifactoryPublish") {
+            publications("maven")
+        }
     }
 }
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -1,3 +1,13 @@
+pluginManagement {
+    repositories {
+        mavenCentral()
+        gradlePluginPortal()
+        maven {
+            name = "Fabric"
+            url = uri("https://maven.fabricmc.net/")
+        }
+    }
+}
 plugins {
     id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0"
 }

diff --git a/worldedit-fabric/build.gradle.kts b/worldedit-fabric/build.gradle.kts
@@ -3,25 +3,14 @@ import net.fabricmc.loom.api.LoomGradleExtensionAPI
 import net.fabricmc.loom.configuration.FabricApiExtension
 import net.fabricmc.loom.task.RemapJarTask
 
-buildscript {
-    repositories {
-        mavenCentral()
-        maven {
-            name = "Fabric"
-            url = uri("https://maven.fabricmc.net/")
-        }
-    }
-    dependencies {
-        classpath("net.fabricmc:fabric-loom:${versions.loom}")
-    }
+plugins {
+    id("fabric-loom")
+    `java-library`
 }
 
 applyPlatformAndCoreConfiguration(javaRelease = 17)
 applyShadowConfiguration()
 
-apply(plugin = "fabric-loom")
-apply(plugin = "java-library")
-
 val minecraftVersion = "1.20.4"
 val loaderVersion = "0.15.1"