Fix or suppress deprecation warnings in most code #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octylFractal
added
status:accepted
Didn't touch commands or some of Sponge
octylFractal
force-pushed
the
cleanup/remove-many-deprecation-warnings
branch
from
f4aecee
to
f64a020
Compare
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
=========================================
Coverage 14.99% 14.99%
Complexity 1270 1270
=========================================
Files 778 778
Lines 33123 33136 +13
Branches 3939 3940 +1
=========================================
+ Hits 4967 4969 +2
- Misses 27750 27761 +11
Partials 406 406
Continue to review full report at Codecov.
|
me4502
reviewed
Jun 30, 2020
| @@ -162,11 +162,15 @@ public void deleteChunks(Actor actor, World world, LocalSession session, | |||
| throw new StopExecutionException(TextComponent.of("Failed to write chunk list: " + e.getMessage())); | |||
| } | |||
|
|
|||
| actor.print(String.format("%d chunk(s) have been marked for deletion the next time the server starts.", | |||
| newBatch.getChunkCount())); | |||
| actor.print(TextComponent.of( | |||
There was a problem hiding this comment.
I was using the deprecation marker for these to indicate it's not translatable yet. Maybe worth making these translatable rather than fixing deprecation by using TextComponent directly
me4502
approved these changes
Jun 30, 2020
wizjany
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't touch commands or some of Sponge