Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Console/CommandBlock support to Fabric/Forge/Sponge #2317

Merged

Conversation

me4502
Copy link
Member

@me4502 me4502 commented May 17, 2023

Adds console & command block support to Forge, Fabric, & Sponge. Is semi awkward for console due to the weird world names (Fabric uses world_minecraft:overworld???)

Targeted 7.2.x as this is platform parity rather than a "new" feature

@me4502 me4502 requested a review from a team May 17, 2023 13:25
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2317 (4be312d) into version/7.2.x (bd9af40) will decrease coverage by 0.04%.
The diff coverage is 0.50%.

❗ Current head 4be312d differs from pull request most recent head 2358240. Consider uploading reports for the commit 2358240 to get more accurate results

@@                Coverage Diff                 @@
##             version/7.2.x   #2317      +/-   ##
==================================================
- Coverage             9.11%   9.08%   -0.04%     
  Complexity            1097    1097              
==================================================
  Files                  843     848       +5     
  Lines                45407   45583     +176     
  Branches              5080    5087       +7     
==================================================
+ Hits                  4140    4141       +1     
- Misses               41073   41248     +175     
  Partials               194     194              
Impacted Files Coverage Δ
...89q/worldedit/bukkit/BukkitBlockCommandSender.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/bukkit/BukkitConfiguration.java 0.00% <ø> (ø)
.../extension/platform/AbstractCommandBlockActor.java 0.00% <0.00%> (ø)
.../sk89q/worldedit/util/PropertiesConfiguration.java 0.00% <0.00%> (ø)
...va/com/sk89q/worldedit/util/YAMLConfiguration.java 0.00% <0.00%> (ø)
...ava/com/sk89q/worldedit/fabric/CommandWrapper.java 0.00% <0.00%> (ø)
...java/com/sk89q/worldedit/fabric/FabricAdapter.java 0.00% <0.00%> (ø)
...89q/worldedit/fabric/FabricBlockCommandSender.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/fabric/FabricCommandSender.java 0.00% <0.00%> (ø)
...java/com/sk89q/worldedit/forge/CommandWrapper.java 0.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wizjany
Copy link
Collaborator

wizjany commented May 18, 2023

does it make sense to hoist the config to core now that it's (mostly) cross-platform? also potentially make an interface in core that notates those platform impls as commandblock/console senders. would be useful for automatically determining if things like //schem load should block instead of being async. also would be useful to avoid issues like EngineHub/WorldGuard#1724

@me4502
Copy link
Member Author

me4502 commented May 20, 2023

I'll hoist the config option, and make a common one for command blocks. IMO we already have a good class to designate "console" in these PRs, as we don't actually add these as console, they're just "non-player sender that isn't an already handled type". So AbstractNonPlayerActor already covers it enough IMO

@me4502 me4502 force-pushed the chore/add-console-command-block-to-fabric-forge branch from 2a26e27 to 4be312d Compare May 21, 2023 07:18
@me4502 me4502 enabled auto-merge (squash) May 21, 2023 07:18
@me4502 me4502 force-pushed the chore/add-console-command-block-to-fabric-forge branch from 4be312d to c86523b Compare June 9, 2023 10:21
@me4502 me4502 changed the title Add Console/CommandBlock support to Fabric/Forge Add Console/CommandBlock support to Fabric/Forge/Sponge Jun 9, 2023
@me4502 me4502 disabled auto-merge June 9, 2023 11:05
@me4502 me4502 merged commit 40a203c into version/7.2.x Jun 9, 2023
7 checks passed
@me4502 me4502 deleted the chore/add-console-command-block-to-fabric-forge branch June 9, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants