-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Console/CommandBlock support to Fabric/Forge/Sponge #2317
Add Console/CommandBlock support to Fabric/Forge/Sponge #2317
Conversation
Codecov Report
@@ Coverage Diff @@
## version/7.2.x #2317 +/- ##
==================================================
- Coverage 9.11% 9.08% -0.04%
Complexity 1097 1097
==================================================
Files 843 848 +5
Lines 45407 45583 +176
Branches 5080 5087 +7
==================================================
+ Hits 4140 4141 +1
- Misses 41073 41248 +175
Partials 194 194
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
does it make sense to hoist the config to core now that it's (mostly) cross-platform? also potentially make an interface in core that notates those platform impls as commandblock/console senders. would be useful for automatically determining if things like //schem load should block instead of being async. also would be useful to avoid issues like EngineHub/WorldGuard#1724 |
I'll hoist the config option, and make a common one for command blocks. IMO we already have a good class to designate "console" in these PRs, as we don't actually add these as console, they're just "non-player sender that isn't an already handled type". So |
2a26e27
to
4be312d
Compare
4be312d
to
c86523b
Compare
Adds console & command block support to Forge, Fabric, & Sponge. Is semi awkward for console due to the weird world names (Fabric uses
world_minecraft:overworld
???)Targeted 7.2.x as this is platform parity rather than a "new" feature