Add support for delegating permissions checks to Sponge when installed #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'd be better off speaking to SK about a proper implementation of WEPIF for Forge/Sponge - the current system is a crude one for FE interoperability. I'll need to sit down and look at this later if you want a more detailed response. |
|
This isn't really intended to be a full system, just a quick hack until sponge support is properly in WE. @kenzierocks suggested I ping you -- I think he was mostly concerned about whether this would break anything FE does. |
|
I am planning to add code for FE 1.8 to not use WorldEdit-Forge (and by extension, this API) if Sponge and WorldEdit-Sponge is installed, and to use WorldEdit-Sponge instead. Go ahead if you want, then. |
zml2008
added a commit
that referenced
this pull request
Jul 22, 2015
When Sponge is not installed, behaviour is as before. Closes #331
octylFractal
pushed a commit
that referenced
this pull request
Jan 12, 2016
When Sponge is not installed, behaviour is as before. Closes #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Sponge permissions plugins to be used for permissions checks without having to write a whole Sponge implementation. It should continue to work as previously if Sponge is not installed.
@luacs1998 since you did this system, any thoughts?