Added arrow shooting prevention flag

[Kruithne]

Add basic flag to prevent entities firing a bow in a certain region. Mostly intended for global configuration to prevent bows in general for two main reasons:

1: Prevent mass build-up of arrows without the need for another plug-in to do so.
2: Prevent people firing bows with special effects (such as TNT from another plug-in) in protected regions.

IntelliJ automatically did some re-factoring to the imports here as-well, not necessary but not harmful either.

[DarkArc]

This is a config setting, not a flag. I'm also not sure how useful this would be. Additionally, your choosen event only helps with entity fired arrows, it ignores dispenser fired arrows for example, despite its wording which implies otherwise.

[TomyLobo]

if you use "import foo.*", you can no longer look for usages of class foo.Bar by searching for "foo.Bar" with a plain text editor. That's the harm in your IDE's unasked behaviour

[Kruithne]

@DarkArc Config setting, not flag then, I apologize for my incorrect wording. The reason why I chose a config setting over a flag is because I really only see this being use on a per-world basis and not for smaller regions. It would be rather useful for the reasons I stated, not every server has a use for bows and disabling them if they lack another plug-in to do so would be beneficial.

The reason a server I work on requires such a thing is to prevent bows from another plug-in (with explosions and such) being used in a world that we'd rather them not. It's only a small light-weight inclusion and we deemed it more sensible to include here than create a new plug-in for. I've updated the code to include any arrows fired from a dispenser also, another wording error.

@TomyLobo I fail to see that as a problem but we will agree to disagree, I have reverted the change in my latest commit.

[sk89q]

Perhaps the configuration should be disable-player-arrow-shooting due to the more limited scope.
Edit: Apparently I over-skimmed.

But otherwise, it looks OK to me.

[DarkArc]

This may be a better event http://jd.bukkit.org/rb/apidocs/org/bukkit/event/entity/ProjectileLaunchEvent.html.

Also there are a couple of minor formatting issues... I'll point them out real quick.

[DarkArc]

The lines here are not properly spaced, make sure you are using spaces, and not tabs.

[Kruithne]

I skimmed over the conventions used by accident as I am used to churning to a different convention (personally think Java conventions used here are terrible, ugly and generally harder to follow), so apologies there.

[Kruithne]

I agree on the ProjectileLaunchEvent over EntityShootBow, however I've kept it limited to arrows only as that's what the intended restriction was for, unless it would rather be extended as a value to disable all projectiles from being fired?

[DarkArc]

The top two lines need moved over still, it should be something like:

    if (wcfg.disableArrowShooting && event.getItem().getTypeId() == ItemID.ARROW) {
        event.setCancelled(true);
    } 
}

[TomyLobo]

return;

[TomyLobo]

So we don't forget to add it (and thus waste CPU) should we add something after it.

[Kruithne]

Sorry yanked my comment out of there before you replied after discussing it with another developer, made a commit to fix it.

[DarkArc]

You know, this whole section probably doesn't need to be here. ProjectileLaunch should cover all cases. I don't know if this would save the item from being removed though (and the ProjectileLaunch event wouldn't), someone want to look into that?

[TomyLobo]

In that case, also check whether projectilelaunch prevents an item in a
dispenser from being used up if it's blocked.