Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Extended" fixes and improvements #1926

Merged
merged 91 commits into from
Dec 25, 2021

Conversation

Krutoy242
Copy link
Contributor

@Krutoy242 Krutoy242 commented Jul 9, 2021

These changes were made for the addon E2E - Extended, which I have been developing for a long time, but also work for the original E2E.

This post is made so that Nill and Enigmatica contributors can comment on the changes. Then, the approved changes will be refined and tested.
This is why the code may contain non-existent items - they will be deleted if the changes are confirmed.

Each commit is described in detail.
Enigmatica contributors suggested go directly to the commit list to see all the changes.
Others - check out the verbose list below, with pictures and additional links.



๐“ฉ๐’ฎ ZenScript Changes

  • Misc OreDict.zs changes
    • Set priority
    • Add to fertilizers
    • Remove purged Sawdust from Forestry, ExCompressum and Mekanism
      (they not obtainable anymore)
  • Utils.zs : bunch of handy zs functions (used by process.zs and craft.zs)
  • โš™๏ธ Process.zs: update compats and capabilities
    • Fluid steps. When liquid amount various for different output it clamps to 100/144/500 etc
    • MekEnrichment as one of processing methods
    • New process: process.mash
    • New process: process.magic
    • process.squeeze accept array of inputs
    • Add IE Mixer
  • ๐Ÿงฎ craft.zs

    Craft.zs Release - recipe making helpers. More Info

  • ๐Ÿช“ wood.zs
    • Add saw -> , add saw for ->

๐Ÿ”  MainMenu

  • Move modpack label to fit MC in window

    Right now, main menu cut label to Enigmatic.
    This change make label smaller, so it wouldnt cut

๐Ÿ”ต Mods Changes

  • โ–ฆ ExNihilio

    • More Compressed Entities

      Just brings more fun to game.
      Always happy to find compressed Cow or such

    • and craft

      Scented hives used to spawn Forestry hives

    • Crooking changes
      • Crooks can process any to (was only vanilla ones)
      • can be crooked into
  • โ˜ข๏ธ NuclearCraft

    • Remove worthless Salt recipes

      is already complicated,
      but there is hundreds of useless recipes.
      Mostly its enriching Depleted Fuel or
      centrifuging compound fuel back to ingredients

      There is no pipeline that could use this recipes.
      This recipes only confusing players when they want to understand
      how to build their first Salt Reactor

    • More machines for
    • More machines for
    • remove wrong recipes

      Many machines output wrong dust. Change them to right one

  • ๐ŸŒ  Astral Sorcery

    • craft with ALL knowledge

      As a reward for players who advanced into endgame and dont want to
      search for each missed constellation

    • craft in Starlight Crafting Engine
  • ๐ŸŒก๏ธ Thermal Expansion

    • can be made in
    • rework
      • Buff melting recipes up to 10 buckets from each Clathrate
      • Filling with output , and
  • ๐ŸŒฑ Mystical Agriculture

    • -> buff

      Considering many Ender Pearl sources in modpack,
      previous recipe was too weak

    • Add missed recipe
    • Saplings from Essence recipes

      + providing saplings.
      Expand with unique recipes for saplings from most mods.

      Examples:

      Note, that not all sapling recipes would be added.
      For example, would be skipped.

    • Squeezing &
    • Missed 4 types of dyes from
  • ๐ŸŒณ TwilightForest

    • Increasing the durability of rare items
  • ๐ŸŒด BiomesOPlenty

    • add recycling into instant damage potion
    • make stackable

      For building purposes

  • ๐ŸŒธ Industrial Foregoing

    • & stackable

      Would make easier to use them as recipe ingredients

    • More outputs

      Additional output:

  • ๐ŸŒพ Farming For Blockheads

    • Add to market
  • ๐Ÿƒ Botania

    • Add Colored Glass -> Quark Cave Crystals conversions

      For example:
      ->

    • Add more saplings to sapling cycling
    • : remove, add other 5 Ores
  • ๐Ÿด DarkUtilities

    • and cheaper

      They work too slow and have short radius
      (in comparsion with other ranged hoppers)

  • ๐Ÿ‰ Ice and Fire

    • Add craft because snow villages is disabled
    • make stackable

      Could be useful for fightings when stackable

  • ๐Ÿ Forestry

    • Fix occurances

      This change would make recipes ask for right tier of Circuit,
      but no matter of NBT tags.
      Still, in JEI it would be shown right way with tooltip
      Fit X Electron Tubes

    • and make OreDicted recipe
    • cheaper

      Comparing to other backpack, like Iron Backpacks, they still have too few slots

    • Remove from recipes
    • More fertilizers for Farms with different values

    • New Item - Bee Diversity Store - unique way to collect time from breeding bees

      Adds recipe functions to store bee data inside special device.
      When new bee specie added, reward accumulated in form of ticks.

      As much species are stored, as much time added, exponentially.
      Video: https://imgur.com/9rvPEsT

  • ๐Ÿฎ Animania

    • Mash and some Prime Meat into pieces

      More efficient and automatable way

  • ๐Ÿ‘จโ€๐Ÿญ Mekanism

    • add tooltip about Spawner content

      Box would always have empty line in tooltip,
      but when there would be spawner in it, entity ID would be shown
      Very handy, because Cardboard Boxes are best way to move spawners
      Image

    • Fix Cubes, Fluid & Gas Tanks uncraftable in AE

      Without this change, you should manually paste exist cubes or tanks
      into ME crafting grid, or autocraft wont take them automatically

  • ๐Ÿ‘ฟ Extra Utilities 2

    • mash ->
  • ๐Ÿ’ผ Actually Additionals

    • Add to
    • Fix conversions

      Before, lens would give acces to free from, basically, flowers.
      Now Lens accept any ore-dicted dyes, but output only last ones
      (mostly Artificial Dyes)

      Price - this items lose their color oredict:


      • Through, they are so pricy, nobody should notice that.
    • Remove from
    • More efficient way to mash items

      Alternative recipe for , and

    • less machines for Recycle of Quark Crystals
    • Buff

      Cause AA ingredients cost much more, Leaf Gen need to be signif. buffed
      Now it could be used on Forestry or other tree farms to get rid of excess leaves

  • ๐Ÿ’ฝ Applied Energetics

    • shortcut in
    • More ammo
  • ๐Ÿ“™ AkashicTome

    • Add Forestry guide
  • ๐Ÿ“ญ Storage Drawers

    • Add Sealed content Tooltip

      When broken and sealed (saved content inside),
      drawers would have tooltip with name of first item inside

      For example:
      Sealed: Cobblestone

    • Buff , but make harder recipes

      Usually, all tiers of storage upgrades was skipped.
      First days of playing you use (III) level, and then move straight to last (V).
      With this change, relatively same storage size (x15) would be achieved by level (III).
      Also, last tier (V) crafts from that would encourage
      players to defeat Chaos Guardian earlier, to achieve huge storage spaces.

      Full stack of 7 upgrades (V) would make size of 1,806,336 items (28,224 stacks)

    • craft
    • Half 4x4 size Fix

      Without this change, half 4x4 had same size as full 4x4

  • ๐Ÿ”Œ Industrial Craft 2

    • Unhide craft and other IC2 hidden crafts like
    • in

      Craft straight from blocks in advanced machine

  • ๐Ÿ”จ Tinker's Construct

    • Missed melt recipe for
    • Super with all avaliable patterns

      Need when you dont want to repeatedly craft each ~20 patterns
      This item have shining texture when crafted

    • Clearing of &
    • Molten Quartz and Lapis -> Blocks cast
    • Clay bucket use for casts
  • ๐Ÿ”ฉ RFTools

    • Add all blocks from Quark and Rustic to dimlets

      All of this blocks are harmless and mostly non-exploitable.
      This change mostly needed to add decorative blocks like or
      to build even more beautiful custom worlds

  • ๐Ÿ–ฅ OpenComputers

    • Add missed items to JEI, like Robot
    • Disable Buffer

      Makes possible editing code from RL computer.
      This is tricky option some people dont know exist.
      Extremely handy for programming.

  • ๐Ÿฆฏ Thaumcraft

    • Add aspects for some items

      This items would be handy to melt into aspects

    • visible recipe (original is hidden in JEI)

      This recipe wont change actual mechannics of crafting Salis Mundus,
      just make it visible

  • ๐Ÿงƒ Open Blocks

    • make valid as XP liquid
  • ๐Ÿง™โ€โ™‚๏ธ Cyclic

    • Add uses for and
    • huge drop list

      Magic beans rather than other "thrash" loot tables have HUGE
      amount items, and rare of them are actually valuable.
      Through, automating farming would be a challenge, because get desirable item
      would only have chance 1/1000

      There is current list of items
      (except for mods that not present in E2E like Deep Mob Learning)

  • ๐Ÿงฌ Draconic Evolution

    • cheaper

      EEM allows to extract from living dragon.
      Without this simplify, it would be easier to spawn and defeat
      another dragon rather than craft EEM

    • cheaper

      Draconic chest is Chest + Furnace + Crafting table.
      But no one need such early game stuff on endgame.
      Moving craft to early DE should give chests more uses.

      Also in ingredient could be replaced to
      to make even cheaper, because
      have actually even more space (351) than Draconium Chest (260)

  • ๐Ÿฉธ Blood Magic

    • simplify

      It should be very cheap because can hold only 16 buckets of liquid

    • simplify

      Its used to not so powerful rituals to be that pricy

    • Fix recipe

      Was uncraftable

    • More animals give different amount of blood

      When using near altair

  • ๐Ÿช AdvRocketry

    • Add as fuel for

      Electric Mushroom spawns rarely on one far planet

  • ๐Ÿ›ข๏ธ Immersive Engineering

    • Cheaper

      Modpack have many Conveyors types.
      IE ones could be nice early alternatives for early game,
      but they require too much Iron.
      New recipes would make them much affordable

    • Add missed Metal Slabs recipes

      Recipes would be oredicted now.
      Examples:

  • ๐Ÿ›ธ EnderIO

    • Remove -> grinding

      Pearl should be grinded into

    • cheaper

      This is basically quantity filter with auto input/output

    • x2 Buff

      Power Buffer is twice cheaper than
      but can be increased with good installed capacitor.
      With it gave 40MRF.
      With lvl5 Capacotor - 520MRF

      This should induce players combine Loot Capacitors together.

      Also, fix Basic Capacitor Bank max storage (seems like 0 was missed)

    • Disable Blink Through Unbreakable Blocks

      This would prevent exploiting in Twilight Forest

@ReiDaTecnologia
Copy link

ReiDaTecnologia commented Jul 9, 2021

Rarely i like changes but this one is the few ones that i actually like. Looking forward for it!

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Dec 21, 2021

All changes approved :) yes please, will be merged when you're ready.

Edit: I think the tier IV and V storage drawer recipes are too pricy compared to how much they increase storage.

@Krutoy242
Copy link
Contributor Author

All changes approved :) yes please, will be merged when you're ready.

I waited long time, heh.
Would refine code in few weeks i guess.

Edit: I think the tier IV and V storage drawer recipes are too pricy compared to how much they increase storage.

I would like to hear your suggestions about ingredients.
For me, they must be this pricy, or Drawers would overcome every else storage methods.

@NielsPilgaard
Copy link
Collaborator

Yeah.. sorry about that ๐Ÿ˜…

Agreed, must be pricy, I'll look into suggestions :)

@NielsPilgaard
Copy link
Collaborator

Tier IV, Light Blue Crystal Shard from Actually Additions
Tier V: Litherite from Environmental Tech

What do you think?

@Krutoy242
Copy link
Contributor Author

Tier IV, Light Blue Crystal Shard from Actually Additions

Why so cheap?
Light Blue Crystal Shard is a Diamond Nugget, transformed in Atomic Reconstructor. And Tier IV is twice larger then Tier V before change.

Its actually a huge buff, because Light Blue Crystal Shard is cheaper then an Emerald (previous T5 ingredient). In other word, recipe becomes cheaper and buff size x2.

I would suggest Empowered Emeradic Crystal. Its relatively cheaper than other Empowered Crystals, and actually harder than Emerald.

Tier V: Litherite from Environmental Tech
Litherite sounds fine.

@NielsPilgaard
Copy link
Collaborator

Good point, let's go with the Empowered Emeradic Crystal.

Repo: https://github.com/Krutoy242/Craft.zs

Tested:
- Bone right-click functionality
- Adding and removing recipes programmatically
- Fluid steps. When liquid amount various for different output it clamps to 100/500 etc
- MekEnrichment as one of processing methods
- New process: `process.mash`
- New process: `process.magic`
- `process.squeeze` accept array of inputs
- ID Squeezer input liquid rounded up
- Add IE Mixer
- Add IE Kiln

Tested:
- Old process recipes
- Recipes in new machines (Kiln)
- Parsed XML output in `crafttweaker.log`
Use global function D(data) to wrap IData and get values from it.

Source: https://github.com/Krutoy242/D.zs
- Set priority
- Add [Fertilized Essence] to fertilizers
- Remove purged Sawdust from Forestry, ExCompressum and Mekanism
  (they not obtainable anymore)

Tested:
- New oredicts actually added
- Any other wood pulp except from TE is unobtainable
Without this change, half 4x4 had same size as full 4x4

Tests:
- Drawer became smaller ingame
Tests:
- Tested crafting (from previously crafted Black Hole unit, not taken from JEI)
โ€ฆcipes

Usually, all tiers of storage upgrades was skipped.
First days of playing you use (III) level, and then move straight to last (V).
With this change, relatively same storage size (x15) would be achieved by level (III).

Full stack of 7 upgrades (V) would make [Basic Drawer] size of 1,806,336 items (28,224 stacks)

Tested:
- Tier V craftable
- 7 upgrades enlarges drawer to 28,224 stacks
When broken and sealed (saved content inside),
drawers would have tooltip with name of first item inside

For example:
`Sealed: Cobblestone`

Tested:
- Tooltip added ![Screenshot with tooltip](https://i.imgur.com/KMKcjXf.png)
When using [Dagger of Sacrifice] near altair

Tests:
- Killed Longhorn Bull on Tier V altair gives about ~3400 blood
Was uncraftable

Tests:
- Craftable, bucket consumed, sigil - not.
Its used to not so powerful rituals to be that pricy

Tests:
- Returned to default recipe, craftable ![Recipe Screenshot](https://i.imgur.com/Rmb1NqP.png)
It should be very cheap because can hold only 16 buckets of liquid

Tests:
- Craftable ![New Recipe](https://i.imgur.com/Qgx3buf.png)
Draconic chest is Chest + Furnace + Crafting table.
But no one need such early game stuff on endgame.
Moving craft to early DE should give chests more uses.

Also [Draconic Core] in ingredient could be replaced to [Draconium Block]
to make even cheaper, because [Large Storage Crate]
have actually even more space (351) than Draconium Chest (260)

Tests:
- Craftable on AA Empowerer ![Crafting Process Screenshot](https://i.imgur.com/1KXfCM5.png)
EEM allows to extract [Dragon Egg] from living dragon.
Without this simplify, it would be easier to spawn and defeat
another dragon rather than craft EEM

Tests:
- Craftable on Extended Crafting Piedestal ![Crafting process screenshot](https://i.imgur.com/HhUmlzH.png)
This would prevent exploiting [Staff of Traveling] in Twilight Forest

Tested:
- Traveled to Twilight forest, unable to teleport between Maze levels (they separated with bedrock)
Power Buffer is twice cheaper than [Basic Capacitor Bank]
but can be increased with good installed capacitor.
With [Basic Capacitor] it gave 40MRF.
With lvl5 Capacotor - 520MRF

This should induce players combine Loot Capacitors together.

Also, fix Basic Capacitor Bank max storage (seems like `0` was missed)

Tests:
- Power buffer with T1 capacitor give 40Mrf storage
- Basic Capacitor Bank store 100Mrf
This is basically quantity filter with auto input/output

Tested:
- Craftable
Pearl should be grinded into [Ender Dust] (applied)

Tests:
- Pearl grinds in Ender Dust in AE Quartz Grindstone
- Crooks can process any [Leaves] to [Silkworm]
- [Eyebulb] can be crooked into [Spider Eye]

Tested:
- Croocking TF leaves drops worms
- Only bottom Eyebulb part drops Spider Eye when croocking
They work too slow and have short radius
(in comparsion with other ranged hoppers)

Tested:
- Craftable Just fine
Tested:
- Mashed fine, through, output in 16 items in stack, that more then 8 items max
Recipes would be oredicted now.
Examples: [Copper Slab] [Electrum Slab]

Tested:
- Cheseled Block Of Copper -> Slab recipe
Modpack have many Conveyors types.
IE ones could be nice early alternatives for early game,
but they require too much Iron.
New recipes would make them much affordable

Tested:
- Craftable
Craft straight from blocks in advanced machine

Tested:
- Dense Copper Plate from Chiseled Copper
- Dense Obsidian from Obsidianas exception
This commit would not change anything.
Its need to be here to see actual changes in next commits.
Also reveal previously invisible recipes for:
- [Glowstone Dust]
- [Gunpowder]
- [Rail]
- [Torch]

Also remove Tiny Emerald and tiny Diamond dust recipes (crash on load with them)

Tested:
- New recipes visible in JEI. ![Example of recipe](https://i.imgur.com/6iir6Gw.png)
Additional output:
- [Fertile Soil]
  [Pulped Biomass]
  [Compost]
  [Mulch]
  [Rare Earths]

Tested:
- New sludge produced fine. ![Example output](https://i.imgur.com/4qD6Ixm.png)
Would make easier to use them as recipe ingredients

Tested:
- Stackable
- Tanks with different content not stackable
- Still used in crafts fine
Many machines output wrong dust. Change them to right one

Tested:
- Wrong Quartz Dust unobtainable anymore (crafts not visible in JEI)
Tested:
- Chiseled Ice -> Supercooled Ice in Fluid Transposer
[Molten Salt Reactor Controller] is already complicated,
but there is **hundreds** of useless recipes.
Mostly its enriching Depleted Fuel or
centrifuging compound fuel back to ingredients

There is no pipeline that could use this recipes.
This recipes only confusing players when they want to understand
how to build their first Salt Reactor

Tests:
- Checked JEI for californium fuel salt recipe
Tested:
- Cow Essence -> Milk in Forestry Squeezer
[Nature Essence] + [Wood Essence] providing saplings.
Expand with unique recipes for saplings from most mods.

Examples: [Blossoming Sapling] [Greatwood Sapling] [Bamboo Sapling]

Note, that not all sapling recipes would be added.
For example, [Sacred Oak Sapling] would be skipped.

Tested:
- Recipes exist in JEI
Considering many Ender Pearl sources in modpack,
previous recipe was too weak

Tested:
- New recipe exist in JEI
Right now, main menu cut label to `Enigmatic`.
This change make label smaller, so it wouldnt cut

Teseted:
- Checked main menu
Could be useful for fightings when stackable

Tested:
- Stackable
- Eating works fine
Without this change, you should manually paste exist cubes or tanks
into ME crafting grid, or autocraft wont take them automatically

Tested:
- Added recipes to ME for each cube (from JEI by "+" button)
- Elite Cube crafted from basic ingredients, propertly crafted all previous cubes
Box would always have empty line in tooltip,
but when there would be spawner in it, entity ID would be shown
Very handy, because Cardboard Boxes are best way to move spawners

Tested:
- ![Tooltip screenshot](https://i.imgur.com/O6TUd20.png)
- Buff melting recipes up to 10 buckets from each Clathrate
- Filling with [Cryotheum] output [Signalum Blend], [Lumium Blend] and [Enderium Blend]

Tested:
- Distabilized Clathrate in Fluid transposer turned into Signalum Blend
@Krutoy242
Copy link
Contributor Author

Krutoy242 commented Dec 25, 2021

Force-push Changes:

  • Every commit that actually changes something was described with what tests i did actually.
  • Dreadwood Log -> Dreadwood Planks would start working automatically when Ice&Fire updated
  • Unhide IC2 hidden recipes instead of creating new Nuke recipe
  • Milk Powder commit removed. Somehow IC2 on E2E dont have Milk Powder o_O
  • [Unfired Clay Bucket] used for bucket cast now (instead of fired one)

@NielsPilgaard NielsPilgaard merged commit 3414887 into EnigmaticaModpacks:develop Dec 25, 2021
SSyl pushed a commit to SSyl/Enigmatica2Expert-SSylTweaks that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants