Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different colours? #234

Closed
ajtruckle opened this issue Apr 15, 2020 · 10 comments
Closed

Different colours? #234

ajtruckle opened this issue Apr 15, 2020 · 10 comments
Labels
EnlighterJS v2 legacy EnlighterJS (based on MooTools Framework) qa/validated quality assurance - code/contribution meets the requirements wontfix

Comments

@ajtruckle
Copy link

Hi
Is it just me or are these colours changing?

Query1

For example, font-size looks darker on line 203 and lighter on line 211.

Why would this happen?

@AndiDittrich
Copy link
Member

use the element inspector of your webbrowser and check the color codes

@ajtruckle
Copy link
Author

Good thinking!

  • The first one is: #085789 (class kw1)
  • The second one is #4284ae (class kw3)

@AndiDittrich
Copy link
Member

sry i didn't take a closer look....this is an issue related to the tokenizer engine in v2 - please use EnlighterJS v3 to fix it

@AndiDittrich AndiDittrich added EnlighterJS v2 legacy EnlighterJS (based on MooTools Framework) qa/validated quality assurance - code/contribution meets the requirements wontfix labels Apr 15, 2020
@ajtruckle
Copy link
Author

Ok, but EnlighterJS v3 is part of your beta WordPress plugin isn't it? You don't yet have copy I can use on my website with bbPress? Were there not some issues? Or is there another way to use EnlighterJS v3?

@AndiDittrich
Copy link
Member

currently you can only fix your bbpress theme and remove the weak css rule

@ajtruckle
Copy link
Author

currently you can only fix your bbpress theme and remove the weak css rule

Sadly, that is beyond my knowledge. I don't really know what to fix. Minor things I am Ok to sniff out and tweak but bigger ...

@AndiDittrich
Copy link
Member

i didn't have the time to fix it for you right now...i'm working on the v4 release

@ajtruckle
Copy link
Author

I understand. I have just downloaded your latest beta and tried it on the staging site:

Issue

I can see teh colour issue I raised is indeed resolved with EnlighterJS v3. But I don't remember how I can actually fix that problem with it is showing the raw code understand the formatted code in the bbPress topics.

@AndiDittrich
Copy link
Member

see #224 (comment)

remove display:block

@ajtruckle
Copy link
Author

Ah, that was it. So I have pursued that line of enquiry here with bbPress:

https://bbpress.org/forums/topic/css-styling-query/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnlighterJS v2 legacy EnlighterJS (based on MooTools Framework) qa/validated quality assurance - code/contribution meets the requirements wontfix
Projects
None yet
Development

No branches or pull requests

2 participants