Closing memory leak in BigWig reader

Ensembl · Dec 26, 2020 · 5ca6e17 · 5ca6e17
1 parent 5a4cdc3
commit 5ca6e17
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/TODO.txt b/TODO.txt
@@ -1,4 +1,3 @@
-Hold fire on writers
 Seekable apply_paste
 Memory tracking & cleaning of chrom labels for text files
 Read score in BigBed files? => Handling overlapping iterators with value in unit and filter

diff --git a/src/bigBedReader.c b/src/bigBedReader.c
@@ -49,8 +49,10 @@ static int readBigBedRegion(BigBedReaderData * data, char * chrom, int start, in
 		return 0;
 
 	while(iter->data) {
-		if (readIteratorEntries(iter, chrom, data))
+		if (readIteratorEntries(iter, chrom, data)) {
+			bwIteratorDestroy(iter);
 			return 1;
+		}
 		iter = bwIteratorNext(iter);
 	}
 	bwIteratorDestroy(iter);

diff --git a/src/bigWiggleReader.c b/src/bigWiggleReader.c
@@ -56,8 +56,10 @@ static int readBigWiggleRegion(BigWiggleReaderData * data, char * chrom, int sta
 		return 0;
 
 	while(iter->data) {
-		if (readIteratorIntervals(iter, chrom, data))
+		if (readIteratorIntervals(iter, chrom, data)) {
+			bwIteratorDestroy(iter);
 			return 1;
+		}
 		iter = bwIteratorNext(iter);
 	}
 	bwIteratorDestroy(iter);