Skip to content

Commit

Permalink
Merge pull request #297 from CristiGuijarro/fix/compara_dcs_e102
Browse files Browse the repository at this point in the history
Fix/compara dcs for e102
  • Loading branch information
james-monkeyshines committed Sep 2, 2020
2 parents f532e30 + 914b82a commit 07e3098
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion lib/Bio/EnsEMBL/DataCheck/Checks/CheckHomologyMLSS.pm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ sub tests {
my ($self) = @_;
my $dba = $self->dba;
my $helper = $dba->dbc->sql_helper;
my @method_links = qw(ENSEMBL_ORTHOLOGUES ENSEMBL_PARALOGUES ENSEMBL_HOMOEOLOGUES);
my @method_links = qw(ENSEMBL_ORTHOLOGUES ENSEMBL_PARALOGUES ENSEMBL_HOMOEOLOGUES ENSEMBL_PROJECTIONS);

my $expected_homology_count;

Expand Down
20 changes: 11 additions & 9 deletions lib/Bio/EnsEMBL/DataCheck/Checks/MemberProductionCounts.pm
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,17 @@ sub tests {

my @counts = ($family_count, $genetree_count, $cafetrees_count, $genetree_count, $genetree_count, $polyploid_count);

if ( $division =~ /vertebrates/ && $collection =~ /default/ ) {
my $desc_5 = "The sum of entries for families in gene_member_hom_stats > 0 for the $collection collection";
cmp_ok( $sums->[0]->{sum_families}, ">", 0, $desc_5 );
my $desc_6 = "There are entries in the family table";
cmp_ok( $counts[0], ">", 0, $desc_6 );
my $desc_7 = "Found expected entries in gene_member_hom_stats with families > 0 for the $collection collection";
my $desc_8 = "There were no unexpected entries in gene_member_hom_stats with families > 0 for the $collection collection";
is( $sums->[0]->{sum_families} > 0, $counts[0] > 0, $desc_7 );
}
#Test for families commented out for duration of compara production freeze, this may return in the future

# if ( $division =~ /vertebrates/ && $collection =~ /default/ ) {
# my $desc_5 = "The sum of entries for families in gene_member_hom_stats > 0 for the $collection collection";
# cmp_ok( $sums->[0]->{sum_families}, ">", 0, $desc_5 );
# my $desc_6 = "There are entries in the family table";
# cmp_ok( $counts[0], ">", 0, $desc_6 );
# my $desc_7 = "Found expected entries in gene_member_hom_stats with families > 0 for the $collection collection";
# my $desc_8 = "There were no unexpected entries in gene_member_hom_stats with families > 0 for the $collection collection";
# is( $sums->[0]->{sum_families} > 0, $counts[0] > 0, $desc_7 );
# }
if ( $division =~ /vertebrates/ || $collection =~ /default/ ) {
my $desc_5 = "The sum of entries for gene_trees in gene_member_hom_stats > 0 for the $collection collection";
cmp_ok( $sums->[0]->{sum_gene_trees}, ">", 0, $desc_5 );
Expand Down

0 comments on commit 07e3098

Please sign in to comment.