Updated to only compare the number of species.alias entrys.

Ensembl · Mar 27, 2023 · e9c1076 · e9c1076
1 parent ec9e4ab
commit e9c1076
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/Bio/EnsEMBL/DataCheck/Checks/CompareSpeciesAlias.pm b/lib/Bio/EnsEMBL/DataCheck/Checks/CompareSpeciesAlias.pm
@@ -38,6 +38,7 @@ use constant {
 };
 
 sub skip_tests {
+    my ($self) = @_;
     my $old_dba = $self->get_old_dba();
     if (not defined $old_dba) {
         return (1, 'New database');
@@ -46,18 +47,16 @@ sub skip_tests {
 
 
 sub tests {
+    my ($self) = @_;
     my $old_dba = $self->get_old_dba();
     my $mca = $self->dba->get_adaptor('MetaContainer');
     my $old_mca = $old_dba->get_adaptor('MetaContainer');
 
     my @new_alias = $mca->list_value_by_key('species.alias');
     my @old_alias = $old_mca->list_value_by_key('species.alias');
 
-    my %new_aliases = map { $_ => 1 } @new_alias;
-
-    for my $element (@old_alias) {
-        ok(exists($new_aliases{$element}), 'Old species.alias is found in new database');
-    }
+    my $description = 'Number of species.aliases did not decrease';
+    ok($#old_alias <= $#new_alias, $description );
 
 }