Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test to make sure that the current regulatory build has a sample … #17

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

thomasmaurel
Copy link
Contributor

@coveralls
Copy link

Pull Request Test Coverage Report for Build 40

  • 8 of 16 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 73.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Bio/EnsEMBL/DataCheck/Checks/SampleRegulatoryFeatureExists.pm 8 16 50.0%
Totals Coverage Status
Change from base Build 38: -0.2%
Covered Lines: 1305
Relevant Lines: 1781

💛 - Coveralls

With datachecks, we want to avoid really long SQL lines that were prevalent in healthchecks, and that impeded readability/maintainability.
@james-monkeyshines james-monkeyshines merged commit 8234463 into master Sep 11, 2018
@james-monkeyshines james-monkeyshines deleted the new_test/SampleRegulatoryFeatureExists branch September 11, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants