Foreign Key datacheck for compara

[james-monkeyshines]

The existing ForeignKeys datacheck has been adapted to the compara use case, i.e. using the foreign keys definitions in the table.sql file, rather than the foreign_keys.sql file that other teams use.

This datacheck includes the functionality from all compara.ForeignKey* healthchecks. It seems to run in reasonable time, so I don't see a pressing need to split it out in order to run in parallel. (It's a bit tricky to do anyway, now that most tests are derived from the SQL file - you'd probably have to do some rather inelegant regex matching on tables names).

There are several species_tree_node and genomic_align_tree checks (Lines 89-96) which were defined in the HCs but which are not present in the table.sql file. The comparable gene_tree_node checks are in the SQL file, so I'm not sure if it makes sense to add the species_tree_node and genomic_align_tree constraints there, and delete these lines from the datacheck?

[coveralls]

Pull Request Test Coverage Report for Build 829

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.578%

---

Totals
Change from base Build 809:	0.0%
Covered Lines:	1802
Relevant Lines:	1828

---

💛 - Coveralls

[muffato]

Thank you @james-monkeyshines .
I would have to check if our API does things in the right order before adding those FK to table.sql. I'll create a ticket for this. In the meantime, I'd leave those FK checks here in the DC