Healthchecks to datachecks #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1081
💛 - Coveralls |
james-monkeyshines
suggested changes
Mar 27, 2020
There was a problem hiding this comment.
This PR also includes the code from #216, so I haven't commented on those bits.
added 14 commits
April 8, 2020 12:04
… fields are the same - if any rows are, then we fail the test
james-monkeyshines
force-pushed
the
healthchecks_to_datachecks
branch
from
fca6fbf
to
d79449b
Compare
added 4 commits
April 8, 2020 12:51
…bles in metadata, datacheck description, and reformatted SQL for clarity.
…necessary query involves the object_xref table, which is species-centric. Updated set of tables in metadata, datacheck description, and reformatted SQL for clarity.
…e the same result with API calls, which is a lot clearer and easier to maintain. It takes longer, but we're talking seconds rather than milliseconds, so an acceptable price to pay for clarity.
james-monkeyshines
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new datachecks: