New compara datachecks #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 22, 2020 22:19
…ross multiple datachecks.
…ded for gene tree highlighting. Not part of 'compara' group, because this data is reliant on the Protein Features pipeline having been run by the Production team.
…ude skip_tests for MLSS tag datachecks, and change group names to match those currently used.
…dna' table have a coord_system 'sequence_level' attribute.
james-monkeyshines
force-pushed
the
compara_datachecks
branch
from
590202c
to
b9fa65d
Compare
Pull Request Test Coverage Report for Build 1184
💛 - Coveralls |
CristiGuijarro
suggested changes
May 26, 2020
thomasmaurel
approved these changes
May 26, 2020
Co-authored-by: CristiGuijarro <cristig@ebi.ac.uk>
CristiGuijarro
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new compara datachecks.
ForeignKeys gets an update, because there was a healthcheck specific to the ancestral db for the dna table, which is generally useful.
Added to ForeignKeysCompara, to check for MLSS tag links.
Batch of MLSS tag datachecks converted from healthchecks, and a new module, Bio::EnsEMBL::DataCheck::Test::Compara, which contains test methods used by multiple datachecks, to prevent repetitive code.
Gene tree highlighting datacheck, which is for non-verts only, and is not part of the 'compara' group, because it only makes sense to apply it after handover, when the Production team have run the relevant pipeline.