Cross-database compara datachecks + conflict resolution #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it against the production_db.
…database must be in the tested one
Pull Request Test Coverage Report for Build 1378
💛 - Coveralls |
length() is only useful to correct the length of circular slices when start is greater than end. Here start is guaranteed to be lower or equal than end. length() involves additional queries to get the seq_region_id and check whether the slice is circular.
|
OK. I'll push my changes related to DNAFragCore here |
… low memory footprint - Dnafrags too can be batched together. - This works for polyploid components too.
muffato
force-pushed
the
feature/fix_conflicts
branch
from
997d5fa
to
878f7bb
Compare
muffato
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
I have pushed all my changes here and in ensembl-compara. I have also piggybacked a fix in CheckGenomicAlignments (cc @CristiGuijarro ).
The updated DNAFragCore now runs on all species, regardless of the number of regions, but it's much quicker as I have made sure the data are fetched in a small number of queries. The entire set of Vertebrates can be checked in 30 min
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #285 that resolves merge conflicts.