File dump-related datacheck updates. #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 29, 2021 12:35
In order to embded the datacheck in a pipeline for exporting GFF3 formatted for ENA submission, split the existing check on INSDC names into two, because part of it is not relevant. Tweak the INDSC name check to be a bit more general, and to match the ENA submission use case, which requires all top-level sequences to have an INSDC name/synonym.
Added a check for Rapid Release display name. Gave the ENA submission group a more generic name. Both of these datachecks are intended to be run within file dump pipelines, to check that the core databases contain all the information required for dumping.
Pull Request Test Coverage Report for Build 1799
💛 - Coveralls |
marcoooo
reviewed
Jul 2, 2021
marcoooo
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for Rapid Release display name.
Split the existing check on INSDC names into two, because only part of it is needed for exporting GFF3 formatted for ENA submission, and we want to be able to run just that bit. The INDSC name check requires all top-level sequences to have an INSDC name/synonym (rather than a set of named coord_systems), which matches the ENA submission use case.
Both of these datachecks are intended to be run within file dump pipelines, to check that the core databases contain all the information required for dumping (Ensembl/ensembl-production#576).