-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for mitochondrial attribute #401
Conversation
We expect MT seq_regions to have a 'sequence_location' attrib, with a value of 'mitochondrial_chromosome'. This was only being checked if the coord_system name was 'chromosome' - but most new core dbs do not use that name, they have 'primary_assembly' instead. This update splits out the MT stuff to a new datacheck, so that it does not depend on the coord_system name.
Pull Request Test Coverage Report for Build 1850
💛 - Coveralls |
This is intended to fix the bug described in ENSPROD-7111 and ENSINT-914. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving us this update James
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you James :)
This DC does not check Compara databases and I approve it conditionally on positive reviews from the affected teams.
We expect MT seq_regions to have a 'sequence_location' attrib, with a value of 'mitochondrial_chromosome'. This was only being checked if the coord_system name was 'chromosome' - but most new core dbs do not use that name, they have 'primary_assembly' instead.
This update splits out the MT stuff to a new datacheck, so that it does not depend on the coord_system name.