Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for mitochondrial attribute #401

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

james-monkeyshines
Copy link
Contributor

We expect MT seq_regions to have a 'sequence_location' attrib, with a value of 'mitochondrial_chromosome'. This was only being checked if the coord_system name was 'chromosome' - but most new core dbs do not use that name, they have 'primary_assembly' instead.

This update splits out the MT stuff to a new datacheck, so that it does not depend on the coord_system name.

James Allen added 2 commits September 3, 2021 11:14
We expect MT seq_regions to have a 'sequence_location' attrib,
with a value of 'mitochondrial_chromosome'. This was only being
checked if the coord_system name was 'chromosome' - but most
new core dbs do not use that name, they have 'primary_assembly'
instead.

This update splits out the MT stuff to a new datacheck, so that it
does not depend on the coord_system name.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1850

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.682%

Totals Coverage Status
Change from base Build 1842: 0.0%
Covered Lines: 2321
Relevant Lines: 2352

💛 - Coveralls

@james-monkeyshines
Copy link
Contributor Author

james-monkeyshines commented Sep 3, 2021

This is intended to fix the bug described in ENSPROD-7111 and ENSINT-914.
If you're wondering why you're a reviewer for this ticket, it's because you are the current relco, and we are introducing a new process to ensure that people don't get surprised by fixed/updated datachecks when handing over dbs... If you have any questions or think these changes are problematic, please let the Production team know, otherwise please approve it (in general, we intend not to merge PRs until everyone has approved, although we might have to be a bit pragmatic if someone is away and the fix is urgent).

Copy link
Contributor

@gnaamati gnaamati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving us this update James

Copy link
Member

@ipilizota ipilizota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you James :)

This DC does not check Compara databases and I approve it conditionally on positive reviews from the affected teams.

@james-monkeyshines james-monkeyshines merged commit 8e9fd09 into release/105 Sep 8, 2021
@james-monkeyshines james-monkeyshines deleted the bugfix/mt_location branch September 8, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants