Fix test skipping for collection dbs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on databases. The skipping was done at the database level, with species_id=1 deciding whether tests were skipped for all species. Have now separated the logic of skipping a datacheck (which happens at the db-level, e.g. because tables haven't been updated) and the skipping of tests (which happens at the species-level). Seemed to make sense to rename the 'run_tests' method to 'run_datacheck', to match the structure/logic of the code.
Pull Request Test Coverage Report for Build 156
💛 - Coveralls |
thomasmaurel
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was not properly handling the skipping of tests for collection databases. The skipping was done at the database level, with species_id=1 deciding whether tests were skipped for all species. Have now separated the logic of skipping a datacheck (which happens at the db-level, e.g. because tables haven't been updated) and the skipping of tests (which happens at the species-level). Seemed to make sense to rename the 'run_tests' method to 'run_datacheck', to match the structure/logic of the code.