Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete old reg. build checks #535

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Delete old reg. build checks #535

merged 2 commits into from
Mar 13, 2023

Conversation

pblins
Copy link
Contributor

@pblins pblins commented Mar 13, 2023

Considering the new reg. build approach, two checks are no longer relevant:

  • EpigenomeHasSegmentationFile
  • ReadFileNames

They were removed in this PR.

marcoooo
marcoooo requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@marcoooo marcoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove the related entries from the index.json

ensembl-datacheck/lib/Bio/EnsEMBL/DataCheck/index.json

Line 1383 in 92765f9

"EpigenomeHasSegmentationFile" : {

and

ensembl-datacheck/lib/Bio/EnsEMBL/DataCheck/index.json

Line 2218 in 92765f9

"ReadFileNames" : {

@pblins
Copy link
Contributor Author

pblins commented Mar 13, 2023

index.json updated.

@coveralls
Copy link

coveralls commented Mar 13, 2023 •
edited

Pull Request Test Coverage Report for Build 2367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.623%
Totals Coverage Status
Change from base Build 2364: 0.0%
Covered Lines: 2364
Relevant Lines: 2397
💛 - Coveralls

@marcoooo marcoooo merged commit 5a6db36 into Ensembl:release/110 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoooo marcoooo marcoooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pblins @coveralls @marcoooo