Last batch of critical funcgen datachecks #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 31, 2019 12:34
…n, not just a subset. But not there yet, so have an interim datacheck to cover the same subset as existing healthcheck.
…n, not just a subset. But not there yet, so have an interim datacheck to cover the same subset as existing funcgen healthcheck.
…stence of data files.
…datacheck was generalised and renamed 'DataFilesExist'
…s always run, regardless of whether the data in the tables has changed. An example of case that needs this is the one that checks funcgen data files - there is an external dependency there, on the data file directory. We don't know if that has changed, so always need to run the test, just in case.
thomasmaurel
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a new core datacheck for analysis descriptions, which I realised we needed after looking at the funcgen version of the same datacheck.