Add config file functionality #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 1, 2019 15:17
…itchy about adding it; but it's the easiest way to do it. If there were more cases of parameters being needed like this, would be better to have a hash which could be populated with whatever key/value pairs are necessary. But I think that'd be overkill at the minute.
…scripts that use those modules.
Pull Request Test Coverage Report for Build 342
💛 - Coveralls |
marcoooo
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to define a config file with all the parameters needed to run a set of datachecks; there are some rarely used parameters which are essentially constant, so it's a pain to have to specify on the command line.
These changes allow for a config file to be created once with the default parameters. Anything passed on the command line overwrites these defaults.