Merge branch 'version/2.5'

* version/2.5:
  bugfix: dbID is not setl to -1 in standaloneJob any more
  Do not report failures on pull-requests
  I can't manage to make the threshold work, so don't mention anything
  Not sure this option is still valid. Anyway, we want to use the config file of the local branch
  This is the default value, no need to mention it

.codecov.yml

@@ -1,16 +1,12 @@
-codecov:
-  branch: master
-  notify:
-    after_n_builds: 1
 
 coverage:
   status:
     project:
       default:
-        threshold: 1%
+        # Don't report failures on pull-requests
+        informational: true
   notify:
     slack:
       default:
         url: secret:LW+i/4NzE9beqqJetobJEJP8GowY1eHWyaiIJM7BB5ZMET5oak4rsGK9zznYFaLQ0jncm46ES7b+aDshLPEMyYp+fvtM/QL0C1+n+nP1tQhzt+kQeFdj5eZA2VBm5qYQq7FuaS1p7PpWEY1EeuQkFWNWQMKNDkeO/ZSrqaiWRUQ=
-        threshold: 1%
 

modules/Bio/EnsEMBL/Hive/RunnableDB/DatabaseDumper.pm

@@ -247,7 +247,7 @@ sub fetch_input {
     # Check whether the current database has been restored from a snapshot.
     # If it is the case, we shouldn't re-dump and overwrite the file.
     # We also check here the value of the "skip_dump" parameter
-    my $completion_signature = sprintf('dump_%d_restored', $self->input_job->dbID < 0 ? 0 : $self->input_job->dbID);
+    my $completion_signature = sprintf('dump_%d_restored', defined $self->input_job->dbID ? $self->input_job->dbID : 0);
 
     if ($self->param('skip_dump') or $self->param($completion_signature)) {
         # A command that always succeeds