Bug fix: Handling multiple tag values #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered in the GTF parser which doesn't handle multiple "tag" values. The GTF files might contain multiple parameters with the key "tag" (in the 9th column), and when read by the parser, each was overwritten by the next ending up with only 1 tag value. This change fixes that and instead creates an array of values if the key occurs more than once.
Note: The GFF3 files have the tags as a comma-separated list so the parser returns it that way. This change might not be completely compatible with GFF3 but I think an array displays the idea of multiple values in a clearer way.