Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/loftee [release/99] #16

Merged
merged 2 commits into from Jan 14, 2020
Merged

Bugfix/loftee [release/99] #16

merged 2 commits into from Jan 14, 2020

Conversation

tuanebi
Copy link
Contributor

@tuanebi tuanebi commented Jan 14, 2020

This PR try to

  1. Adding Loftee checkout to the PERL5LIB, it does not need to be in PATH
  2. Remove loftee_version variable from vars/main.yml as loftee uses different branch for www and grch37.
    The variable should stay in appropriate conf dirs as below
    https://github.com/Ensembl/ensembl-rest_private/commit/202d4868efcbe1257e890450a699befe6f05b33a

The PR should be merged to release/99 and master

nicklangridge
nicklangridge approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@nicklangridge nicklangridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tgrego tgrego changed the title Bugfix/loftee Bugfix/loftee [release/99] Jan 14, 2020
@tgrego tgrego merged commit 2b8948d into Ensembl:release/99 Jan 14, 2020
@tgrego
Copy link
Contributor

tgrego commented Jan 14, 2020

Thanks and please submit against master

@tuanebi tuanebi mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklangridge nicklangridge nicklangridge approved these changes

@tgrego tgrego tgrego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuanebi @tgrego @nicklangridge