Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biotype so_term #342

Merged
merged 8 commits into from Feb 25, 2019
Merged

Biotype so_term #342

merged 8 commits into from Feb 25, 2019

Conversation

tgrego
Copy link
Contributor

@tgrego tgrego commented Feb 20, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • the PR must not fail unit testing
    • if you're adding/updating documentation of an endpoint, make sure you add/update the necessary parameters to the (template) configuration files in the ensembl-rest_private repo

Description

Using one or more sentences, describe in detail the proposed changes.
Biotype table and object in core has been updated to include the so_term (see hhttps://github.com/Ensembl/ensembl/pull/364)
This updates the rest server to include so_term on biotype searches (through the info endpoint).
Test databases have been patched to the latest schema patch, and fixtures updated to match latest schema.

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
Up to date endpoints

Benefits

If applicable, describe the advantages the changes will have.
Up to date endpoints

Possible Drawbacks

If applicable, describe any possible undesirable consequence of the changes.
None I can see

Testing

Have you added/modified unit tests to test the changes?
Yes

If so, do the tests pass/fail?
Pass

Have you run the entire test suite and no regression was detected?
Tests affected passed in isolation

Changelog

Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.

[info/biotypes/]
* [info/biotypes/groups] will now include so_term field in retrieved data.
* [info/biotypes/name] will now include so_term field in retrieved data.

Copy link
Contributor

@markmcdowall markmcdowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine to me

Copy link
Contributor

@premanand17 premanand17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@tgrego tgrego merged commit 7325a1e into master Feb 25, 2019
@tgrego tgrego deleted the biotype_so_term branch December 20, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants