Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 test db patch #52

Merged
merged 1 commit into from
Jul 16, 2020
Merged

103 test db patch #52

merged 1 commit into from
Jul 16, 2020

Conversation

ameya1981
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • the PR must not fail unit testing

Description

103 test db patch

Use case

Part of release SOP

Benefits

In sync test dbs

Possible Drawbacks

NA

Testing

NA

If so, do the tests pass/fail?

NA

Copy link
Contributor

@ens-bwalts ens-bwalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look like those put into core. As with core and io, assuming that if variation has any changes they will come in a separate PR

Copy link

@s-mm s-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ameya1981 ameya1981 merged commit e2e286b into master Jul 16, 2020
mira13 pushed a commit that referenced this pull request Aug 11, 2020
mira13 pushed a commit that referenced this pull request Aug 11, 2020
mira13 pushed a commit that referenced this pull request Aug 11, 2020
mira13 pushed a commit that referenced this pull request Aug 11, 2020
mira13 pushed a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants