Skip to content

Commit

Permalink
Fix loop on sample synonyms in get_all_Samples
Browse files Browse the repository at this point in the history
Two parts bug: instead of looping on all sample_synonyms, only the first
synonym was retrieved at first. So the array ref was dereferenced in a
previous commit, but the second part of the bug was not fixed, which
lead to a string being used as an array.
  • Loading branch information
MatBarba authored and William McLaren committed Sep 6, 2017
1 parent 50122f8 commit bdad449
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/Bio/EnsEMBL/Variation/VCFCollection.pm
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ sub get_all_Samples {
for my $sample_name (keys %sample_objs) {
my $sample = $sample_objs{$sample_name};
for my $syn (@{$sample->get_all_synonyms}) {
$synonyms{$syn->[0]} = $sample->name;
$synonyms{$syn} = $sample->name;
}
}

Expand Down

0 comments on commit bdad449

Please sign in to comment.