Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update billion count icon in docs and other updates #1047

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Update billion count icon in docs and other updates #1047

merged 9 commits into from
Nov 3, 2023

Conversation

nakib103
Copy link
Contributor

@nakib103 nakib103 commented Oct 24, 2023 •
edited

  • add different color for billion counts in pages that list variant counts
  • add chimpanzee and gibbon json in vcf_config.json which somehow got missed.
  • add vcf_species_list_111.json data file
  • fix syntax error in clin_significance generation script which causing failure in generating the tables.
  • fix missing frequency for human in population page (because we were only checking genotype and ignoring frequency)

nuno-agostinho
nuno-agostinho requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@nuno-agostinho nuno-agostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nakib103, thanks for the PR! I left some comments.

scripts/docs/species_list.pl Outdated Show resolved Hide resolved
scripts/docs/sources2html.pl Outdated Show resolved Hide resolved
scripts/docs/sources2html.pl Outdated Show resolved Hide resolved
scripts/docs/sources2html.pl Show resolved Hide resolved
modules/Bio/EnsEMBL/Variation/DBSQL/vcf_config.json Show resolved Hide resolved
nakib103 and others added 2 commits October 30, 2023 11:55
@nuno-agostinho
Copy link
Contributor

Hey @nakib103, all seems fine with this PR, thanks for the changes!

nuno-agostinho
nuno-agostinho approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@nuno-agostinho nuno-agostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nakib103!

@nakib103 nakib103 merged commit ce0f715 into Ensembl:release/111 Nov 3, 2023
1 check passed
@nakib103
Copy link
Contributor Author

nakib103 commented Nov 3, 2023

merged to postreleasefix/112, release/112, and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-agostinho nuno-agostinho nuno-agostinho approved these changes

Assignees

@nuno-agostinho nuno-agostinho

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nakib103 @nuno-agostinho