-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent annotating start_lost
if start codon is retained in case of indels
#1062
Prevent annotating start_lost
if start codon is retained in case of indels
#1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nakib103, I tested this PR with ClinVar VCF file, but it returns this error:
Can't call method "seq" on an undefined value at /hps/software/users/ensembl/repositories/nuno/ensembl-variation/modules/Bio/EnsEMBL/Variation/Utils/VariationEffect.pm line 1050.
You can reproduce the issue with the command:
perl vep --id "5 14664825 1462152 CA C" --database --db_version 111
It seems the issue may be related with $utr
being undefined.
Hi @nuno-agostinho , thanks , fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakib103, looks good to me!
I will wait for the unit tests to finish before merging.
Merged to |
ENSVAR-5777
Test
Check ticket
Update on unit test
atg -> atGCAg
- we still retain the start codon, hence we should returnstart_retained
besideinframe_insertion
CATG -> CAT
- there is another G after the deleted G (see here) , so we should havestart_retained
beside5_prime_UTR_variant