Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEP plugins: retrieve data from specific Tabix-indexed files #1069

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Feb 12, 2024

ENSVAR-2596

Required by Ensembl/VEP_plugins#681

Motivation

Currently, Tabix-indexed data in VEP plugins when using get_data is retrieved in conglomerate from all the files.

This update allows to retrieve data only from a specific file by changing how the cache mechanism is created when get_data gets a file:

  • Nothing should change if the last argument of get_data is not defined, so this change should not affect any plugins
  • If get_data defines a file:
    • Result cache are separated by filename
    • Data is only retrieved for the specified filename

Testing

  1. Test with Improve Paralogues plugin VEP_plugins#681
  2. Test with any plugin that uses get_data function to see if its results are as expected (such as CADD plugin).

@nuno-agostinho nuno-agostinho changed the title VEP plugins: Allow retrieving data from specific Tabix-indexed files VEP plugins: retrieve data from specific Tabix-indexed files Feb 12, 2024
@nuno-agostinho nuno-agostinho marked this pull request as ready for review February 19, 2024 09:33
Copy link
Contributor

@jamie-m-a jamie-m-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original functionality retained, new function added to support selection of specific input

@jamie-m-a jamie-m-a merged commit f5bbeec into Ensembl:postreleasefix/112 Apr 19, 2024
1 check passed
@nuno-agostinho nuno-agostinho deleted the update/specific-tabix-plugins branch April 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants