Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Uploaded_variation #120

Merged
merged 2 commits into from Jan 9, 2018
Merged

Conversation

monsanto-pinheiro
Copy link
Contributor

To backward compatibility and to be equal with documentation is necessary to make a correction in 'modules/Bio/EnsEMBL/VEP/OutputFactory.pm' line 783.

-Uploaded_variation => $vf->variation_name,
+Uploaded_variation => $vf->variation_name ne '.' ? $vf->variation_name : ($vf->{original_chr} || $vf->{chr}).''.$vf->{start}.''.($vf->{allele_string} || $vf->{class_SO_term}),

From your help:
"""
The default output format ("VEP" format when downloading from the web interface) is a 14 column tab-delimited file. Empty values are denoted by '-'. The output columns are:
'Uploaded variation - as chromosome_start_alleles'
"""

fix Uploaded_variation, test 'minimal - output hashes'
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.118% when pulling 11683d1 on monsanto-pinheiro:release/91 into 46e1afe on Ensembl:release/91.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 6, 2018

Coverage Status

Coverage remained the same at 99.118% when pulling 11683d1 on monsanto-pinheiro:release/91 into 46e1afe on Ensembl:release/91.

@at7 at7 merged commit e34bc9f into Ensembl:release/91 Jan 9, 2018
@at7
Copy link
Contributor

at7 commented Jan 9, 2018

Thank you for your pull request. We can include the change for the next release. Could you please commit to the master branch? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants