Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin path in command line output #1535

Merged

Conversation

nuno-agostinho
Copy link
Contributor

Currently, the VEP command-line in output is hiding all plugin parameters preceding a path delimiter (/ or \).

For instance, if we run multiple plugins with a command like:

./vep --i $vcf \
      --cache homo_sapiens/tabixconverted/ \
      --plugin dbNSFP,dbNSFP/4.4a/dbNSFP4.4a_grch38.gz,rs_dbSNP \
      --plugin GO,plugin_data/GO_data_files/ \
      --plugin DisGeNET,file=DisGeNET/May_2020/all_variant_disease_pmid_associations_final.tsv.gz

The output will be:

## VEP command-line: vep --cache [PATH]/ --input_file [PATH]/A530_small.vcf --offline --output_file [PATH]/vep-output.txt --plugin [PATH]/all_variant_disease_pmid_associations_final.tsv.gz

Change log

Testing

The output should be similar to:

## VEP command-line: vep --dir_cache [PATH]/tabixconverted/ --fasta [PATH]/Homo_sapiens.GRCh38.dna.toplevel.fa.gz --force_overwrite --input_file [PATH]/A530_small.vcf --offline --output_file [PATH]/vep-output.txt --plugin dbNSFP,[PATH]/dbNSFP4.4a_grch38.gz,rs_dbSNP --plugin GO,[PATH]/GO_data_files/ --plugin DisGeNET,file=[PATH]/all_variant_disease_pmid_associations_final.tsv.gz

Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nakib103 nakib103 merged commit edc48a0 into Ensembl:postreleasefix/112 Nov 2, 2023
1 check passed
@nuno-agostinho nuno-agostinho deleted the fix/command-plugin-path branch November 2, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants