Test for IndelCoordinate first because IndelCoordinate can be a Gap #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonably sane. There are no tests at all for MappedSlice at the moment, is this the module you are planning to retire next release? |
|
I searched the web-code and compara code for use of the module. It looks like only variation uses it. Therefore, I'm happy to move it into the variation API for release/93 and deprecate it in the core API for 93. Could you do me a favour and cherry pick it into release/92 please? It is a postrelease fix and it would be great to see the resequencing view working again. |
|
Changes are fine with me. Can you please submit a separate pull request against release/92 to add it there? I'll leave it to a second person of Core to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when drawing strain slice sequence against reference sequence in the Resequencing view. Sometimes a IndelCoordinate was treated only as a Gap because Gap is the base class.