Basic analytics #28
Merged
Basic analytics #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enteee
requested changes
Oct 14, 2019
src/app/counter-analytics/day-of-week-histogram/day-of-week-histogram.page.component.ts
Outdated
Show resolved
Hide resolved
src/app/counter-analytics/day-of-week-histogram/day-of-week-histogram.page.component.ts
Outdated
Show resolved
Hide resolved
src/app/counter-analytics/day-of-week-histogram/day-of-week-histogram.page.component.html
Outdated
Show resolved
Hide resolved
src/app/counter-analytics/day-of-week-histogram/day-of-week-histogram.page.component.html
Outdated
Show resolved
Hide resolved
� Conflicts: � src/app/models/count-event.ts
Pull Request Test Coverage Report for Build ace03d3dc7362bd2f063923d057d5fcfd81e2866-PR-28
💛 - Coveralls |
Enteee
requested changes
Oct 29, 2019
| it('should be created', () => { | ||
| expect(service).toBeTruthy(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
getDayOfWeekHistogramData needs some testing here
| import { Counter } from '../models/counter'; | ||
|
|
||
| export type DayOfWeek = 'monday' | 'tuesday' | 'wednesday' | 'thursday' | 'friday' | 'saturday' | 'sunday'; | ||
| const dayOfWeekMappingList: DayOfWeek[] = ['sunday', 'tuesday', 'wednesday', 'thursday', 'friday', 'saturday', 'monday']; |
There was a problem hiding this comment.
saturday, monday, sunday: now in know why everybody hates mondays...
* Add testcase
Enteee
force-pushed
the
feature/basic-analytics
branch
from
8d50477
to
9c7bc1c
Compare
Enteee
approved these changes
Oct 29, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jitz chönntsch mau di Sänf drzue gä.