Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new user #2991

Merged
merged 5 commits into from
Mar 30, 2021
Merged

Added new user #2991

merged 5 commits into from
Mar 30, 2021

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 24, 2021

for issue #2989

Added new users in different stages of signing up

This pull request changes...

  • add a mfa@email.com user that requires MFA and is affiliated to Alaska

  • add a notingroupmfa user that requires MFA but isn't in our group

  • add a lockedoutmfa user that can have their MFA locked out

  • add a expiredmfa user that requires MFA but is expired

  • add a resetmfa user that can have their MFA reset continually without effecting anyone else

  • add a requestedrole user that has requested a role

  • add a deniedrole user that has been denied a role

  • add a revokedrole user that has had their role revoked

  • add a norole user that does not have an affiliation

  • add a norolemfa user that requires MFA and does not have an affiliation

  • add software token QR codes to Keybase for mfa@email.com, notingroupmfa, lockedoutmfa, expiredmfa, resetmfa, and norolemfa

  • add requestedrole, deniedrole, revokedrole to seed with the appropriate affiliation status

This is how to verify this change...

Login with each new user on PR and Staging and verify* that:

  • mfa@email.com -- login and enter MFA, takes the user to the State Dashboard
  • notingroupmfa -- login and enter MFA, takes the user to the Job Code Missing page
  • lockedoutmfa -- put in password correctly, put in one-time password wrong 5 times, takes the user to the Account Locked page
  • expiredmfa -- login and enter MFA, tells user their MFA is wrong (this is not true, but we have ticket [Dev] MFA issue when logging in with an expired password #2988 to address the problem)
  • resetmfa -- login, takes the user to the MFA enroll form
  • requestedrole -- login, takes the user to the pending approval page
  • deniedrole -- login, takes the user to the denied approval page
  • revokedrole -- login, takes the user to the revoked approval page
  • norole -- login, takes the user to the state selection form
  • norolemfa -- login and enter MFA, takes the user to the state selection form
  • please don't submit any of the forms, if you do please reset them in Okta

This pull request is ready to merge when...

  • Develop has updated automated tests (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • QA has manually tested and created bugs for any issues found (beyond minor fixes)
    - [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented
    - [ ] The change has been documented
    - [ ] Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate

This feature is done when...

  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@thetif thetif linked an issue Mar 24, 2021 that may be closed by this pull request
10 tasks
@thetif thetif changed the title updated changelog Added new user Mar 24, 2021
@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #2991 (365a07c) into master (59250e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2991   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         271      271           
  Lines        4982     4982           
  Branches      967      967           
=======================================
  Hits         4423     4423           
  Misses        516      516           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59250e6...365a07c. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 24, 2021

This deploy was cleaned up.

@thetif thetif requested review from knollfear and tbolt March 29, 2021 15:05
@thetif thetif closed this Mar 29, 2021
@thetif thetif reopened this Mar 29, 2021
Copy link
Contributor

@knollfear knollfear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thetif thetif merged commit 4bb73ab into master Mar 30, 2021
@thetif thetif deleted the tforkner/2989-new-seed-users branch March 30, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Create new test users
4 participants