Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret scanning #4529

Merged
merged 4 commits into from Feb 8, 2023
Merged

Secret scanning #4529

merged 4 commits into from Feb 8, 2023

Conversation

yonassrobi
Copy link
Contributor

Resolves ##2352

Description

Implements gitleaks pre-commit hook and github action for guarding secrets from accidentally being committed to this repository.

Developers will need to install gitleaks in their local environment. Installation instruction are found here

Significant changes or possible side effects
None

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@yonassrobi yonassrobi mentioned this pull request Feb 7, 2023
13 tasks
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #4529 (6201ee5) into main (ad36ffb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4529   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files         252      252           
  Lines        7765     7765           
  Branches     1673     1673           
=======================================
  Hits         7318     7318           
  Misses        428      428           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad36ffb...6201ee5. Read the comment docs.

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-18-206-77-240.compute-1.amazonaws.com

@yonassrobi yonassrobi merged commit 3308dfd into main Feb 8, 2023
@yonassrobi yonassrobi deleted the secret-scanning branch February 8, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants