Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the email address of the Export Instructions #4581

Merged
merged 9 commits into from Mar 9, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 2, 2023

Resolves #4313

Description

Updated the export instructions to use different email addresses for HITECH and MMIS.

Steps to manually verify this change

  1. Open a HITECH APD
  2. Click on Export and Submit
  3. Click on Continue to Review
  4. Verify that the email address is MedicaidHITECH@cms.hhs.gov

The Export and Submit page doesn't work for MMIS, but you can validate it through storybook.

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@thetif thetif added the feature PR label for release log label Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #4581 (00ef8e3) into main (b8f9bc9) will decrease coverage by 8.46%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4581      +/-   ##
==========================================
- Coverage   94.26%   85.80%   -8.46%     
==========================================
  Files         264      262       -2     
  Lines        8476     8484       +8     
  Branches     1822     1826       +4     
==========================================
- Hits         7990     7280     -710     
- Misses        464     1105     +641     
- Partials       22       99      +77     
Impacted Files Coverage Δ
web/src/pages/apd/export/ExportReadOnly.js 57.14% <57.14%> (-22.86%) ⬇️

... and 97 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f9bc9...00ef8e3. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 2, 2023

See this pull request in action: https://ec2-54-162-126-137.compute-1.amazonaws.com

00ef8e3


const sendMail = e => {
e.preventDefault();
console.log({ email });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log here

@mirano-darren
Copy link
Contributor

mirano-darren commented Mar 6, 2023

Looks good! I approved the changes on Storybook
Test Cases:

Given When Then
A HITECH APD On the Review page Should show the email: MedicaidHITECH@cms.hhs.gov
An MMIS APD On the Review page Should show the email: MedicaidMMIS@cms.hhs.gov

@thetif thetif requested review from jeromeleecms and SGilliamA1M and removed request for Sun-Mountain March 7, 2023 14:26
Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that email address has been updated for HITECH.

Copy link

@stephanieboydcms stephanieboydcms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks!

@thetif thetif removed the request for review from jeromeleecms March 9, 2023 15:09
@thetif thetif merged commit 4aeccd2 into main Mar 9, 2023
@thetif thetif deleted the tforkner/4313-update-export-and-submit branch March 9, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Update APD Review page for MMIS
7 participants