merge val → prod #11107
Merged
merge val → prod #11107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MDCT-2293] Uploads Timeout, also increase mem for potential speedup
* hide the thing behind a ld flag * add MLR button to homepage * remove button * fix unit tests * one more test * suggested change on tests * deconstruct flags * matching in other files * update tests and logic
* MDCT-2093 - Last Saved Time in Form Header (#4782) * last saved time in header * final checks * MDCT-2092: Button Verbiage Changes for AutoSave Experience (#4779) * Button verbiage * Button type * Unit tests * Button styling changes * wip * text field poc * text poc part ii * conditional autosaving; pacify dom attr console errors * fix failing tests * alter leave form button and last saved on mobile (#4839) * allow empty inputs in ssv * blanks are totally in now * remove outdated tests from standardreportpage * one test hanging on to old render? * tests needed to call mockGetValues() to set hydration value * Fix dynamic fields autosaving * Update DynamicField.tsx * Fix blur at same time as add a row plan bug * Add DynamicField autosave tests * Make datefields autosave if necessary * Fix identical code block * Add dropdowns to autosave * Add test to blanked dynamic fields * update dynamic field for autosave refresh error * Add onblur autosave to numberfields * Add tests for numberfield autosave * Update services/ui-src/src/components/fields/NumberField.test.tsx Co-authored-by: Brax Excell <braxton@coforma.io> * Pass sxOverride instead to add with to dynamicfields * Swap from getByTestID to getByLabelText * Swap from getByTestID to getByLabelText * autosave radio/checkboxes (#5297) * added autosave to checkbox field * Write first test for Choicelists * Update CheckboxField.tsx * testing for NOT updating if admin user and if autosave is off Co-authored-by: Nicholas Summers <nick@coforma.io> * Remove unneeded test-ids * fix missed label text * brax updates and bug fixes * minor updates * adding schemaMap test with TODO * adding report header check * testable component for endDate testing * clear naming * Clear nested (#5354) * choice list fix start * Clear nested fields uncleaned * Allow for nested fields to be cleared * Create helpers for autosave and implement it in TextField * Fix comparison in valueChanged helper * Make valueChanged comparison not exported * Keep better track of last value in textfields * Add sending of data only on data change to numberfields * Add datefields to only autosave on change * Add Dropdowns to only autosave on change * Make sure hydration doesn't trigger unneeded autosaves * Conquer Dynamicfield Autosaving too many times * Change LastValue to LastAutosaveValue for clarity * Swap to oncomponentblur for autosave on choicelist * A one line fix that was so simple i hate myself * helpers test start * Mock formtrigger for helper functions for autosave * Make sure validation isn't too agressive if just tabbing through fields * Only send data thats necessary for ChoiceList * The Brax Edit * utility (wip draft) (#5355) * text field proof of concept * extend poc to choicelist; allow multi-field autosave functionality via utility method * little cleanup * a lil update * extend functionality to date, dropdown, number * push code up because * unreducied * gah * DONT LOOK AT MY SHAME * getting closer * Add lodash deep equality check * Remove console logs --------- Co-authored-by: Nicholas Summers <nick@coforma.io> --------- Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io> * remove user prop * dynamic fields working great * remove lodash * a little cleanup * remove unnecessary backend schema mod * final cleanup * oops too cleanup * Add tougher if statement for checking what fields should be saved * Further expand on if statement to handle dynamic fields * Set stage for fixing choicelist autosaving * Get all fields and DynamicFields to update appropriately * Remove missed attempts to fix choicelist * Get everything in a stable state * 95% validation correctly set for radio/checkboxs * Slight reduction of redundant code * timeout to work with cmsds choicelist blur * populate data for textFields & check parent in choiceList * remove unnecessary form update after autosave * reduce hydration * choicelist cleanup * autosave util cleanup * clean up field type pass-through * a little cleanup, plus a question * fix a bug * autosave tests (#5395) * autosave tests * full coverage * Update autosave.ts * remove admin user tests * datefield coverage * Fix RadioField test file * Update TextField.test.tsx * Add Dynamicfield tests * Update autosave tests from Brax's updates * Bugged Choicelist test that are ending after a test finishes * Maybe possibly working Choicelist test? * Get working autosave test * Update ChoiceListField.test.tsx * uncheckedOptionValues * Add tests for handling nested choicelist children * Remove mocking of formFieldFactory * Fix autosave tests due to new returns for dynamic field --------- Co-authored-by: Nicholas Summers <nick@coforma.io> * resolving review comments * a few more nits * dynamic field mobile styles * add autosave cypress * fixing blur issue --------- Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com> Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: Scott Wambach <scott.wambach@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: BearHanded <bcm3223@gmail.com>
* Explicit declarations of serverless components * adding db svls stage * Mr. Cypress goes to Washington.
pa11y needs a fix for local testing.
* Fix overzealous textbox error * Add additional validation update when hydrating * Remove formset --------- Co-authored-by: Nicholas Summers <nick@coforma.io>
* cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this.
* adding MLR resources * indentation and reference fix * serverless fix * how about I actually fix it * duplicate removal
* Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler
* Add choicelist updates to follow issue in github * Possible fix by removing final render call and setting fieldValue in useEffect * Make radio fields listen for updates and clear their children * Allow textboxes to be cleared when nested in a choicelist * Make reportfooter navigate to the next page + submit form when navigating * fix one test * fix that second failing unit test * coverage * fix failing test * actually fix it * okay hbn * Add clear prop tests * Add tests for clearing children of choicelists * remove unnneeded shouldValidate * Fix type nit * Add test for checkboxs clearing radio children * nested checkbox test --------- Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: karla-vm <karla@coforma.io>
* modifying to handle MLR repor * archive and update * placeholder env file * update * removing comments * Update services/app-api/handlers/reports/archive.ts Co-authored-by: Brax Excell <braxton@coforma.io> * refactor tables and buckets as constants for each report type * nit * nit across the lands * cleaner naming for buckets + tables * prepping API for fetch * and tests * pushing for tests * add params where needed * update handlers and tests * actually pass the tests, right * path params serverless * merge conflict issue * hash update to resolve serverless 2->3 breaking change * fix autosave tests * validating report keys prior as a function * remove todo * feedback * Merge MLR changes on top of refactored APIs (#11092) * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * prepping API for fetch * pushing for tests * add params where needed * validating report keys prior as a function * feedback --------- Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com> Co-authored-by: karla-vm <karla@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> * changes to match MLR and NAAAR * merge conflict fixes * AHA a typo * removing deploy enforcement * serverless path changes * reportkeys --------- Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: BearHanded <bcm3223@gmail.com> Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Oren Weingrod <124941331+oweingrod-coforma@users.noreply.github.com>
* modifying to handle MLR repor * archive and update * placeholder env file * update * removing comments * Update services/app-api/handlers/reports/archive.ts Co-authored-by: Brax Excell <braxton@coforma.io> * refactor tables and buckets as constants for each report type * nit * nit across the lands * cleaner naming for buckets + tables * prepping API for fetch * and tests * pushing for tests * add params where needed * update handlers and tests * actually pass the tests, right * path params serverless * merge conflict issue * hash update to resolve serverless 2->3 breaking change * fix autosave tests * validating report keys prior as a function * remove todo * feedback * replicate changes * onchange issue * Merge MLR changes on top of refactored APIs (#11092) * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * prepping API for fetch * pushing for tests * add params where needed * validating report keys prior as a function * feedback --------- Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com> Co-authored-by: karla-vm <karla@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> * changes to match MLR and NAAAR * merge conflict fixes * AHA a typo * removing deploy enforcement * serverless path changes * reportkeys --------- Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: BearHanded <bcm3223@gmail.com> Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Oren Weingrod <124941331+oweingrod-coforma@users.noreply.github.com>
* fix that dashboard spec * sidebar * how did that go through
Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 5.3.1 to 5.4.0. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v5.3.1...5.4.0) --- updated-dependencies: - dependency-name: dns-packet dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…n/services/ui-src/dns-packet-5.4.0 Bump dns-packet from 5.3.1 to 5.4.0 in /services/ui-src
merge dev → val
braxex
requested review from
karla-vm,
TheDanMiller,
BearHanded,
ntsummers1,
scwambach,
britt-mo and
tblackwe
as code owners
britt-mo
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Merging val/impl→ production at product owner request.
In this deployment:
/reportsendpoint API handlers (11082)Related ticket
n/a
How to test
n/a
Important updates
n/a