Fix Artifact Upload

[berryd]

Description

There were a few problem with the artifact upload:

• Unit tests were configuration in such a way that they would probably not upload artifacts should the tests fail. Also api unit tests were not being packaged.
• Cypress and A11y test paths pointed to directories one level deeper than they were actually being stored.
• Cypress and A11y artifact name would produce a collision and fail the job, so if both failed, the slower job would not be able to upload artifacts
• No retention was set so it would default to 90 days. I picked 14 because I wouldn't expect to need to retrieve artifacts from a build older than 2 weeks

Related ticket(s)

CMDCT-3552

---

How to test

I pushed a build set to always upload artifacts. The artifacts can be seen to be correctly publishing here. A successful build will not produce artifacts.

---

Pre-review checklist

• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary
• I have performed a self-review of my code
• I have manually tested this PR in the deployed cloud environment

---

Pre-merge checklist

Review

• Design: This work has been reviewed and approved by design, if necessary
• Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

• These changes are significant enough to require an update to the SIA.
• These changes are significant enough to require a penetration test.

---

convert to a different template: test → val | val → prod

[codeclimate]

Code Climate has analyzed commit b39ebc8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.