Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks to make cypress run better #11704

Merged
merged 1 commit into from
May 21, 2024
Merged

Some tweaks to make cypress run better #11704

merged 1 commit into from
May 21, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented May 21, 2024

Description

  • Borrow the "archive reports before running tests" idea from MFP
  • Add wait after clearing auth sessions
    • This seemed to reduce retries that happen as a result of the old session still being active
  • Rewrite sidebar commands to ensure it's entering the correct report

I ran these against local and against MCR dev. Especially in the dev env I saw fewer retries and more reliable outcomes.


How to test

  • Run tests
  • Tests pass in this branch

Only one retry happened in the tests
https://github.com/Enterprise-CMCS/macpro-mdct-mcr/actions/runs/9177706206/job/25236861227?pr=11704

Copy link

codeclimate bot commented May 21, 2024

Code Climate has analyzed commit b20b613 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian added the ready for review Ready for all the reviews! label May 21, 2024
@gmrabian gmrabian merged commit f04feba into main May 21, 2024
21 checks passed
@gmrabian gmrabian deleted the fix-cypress-again branch May 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants